hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(sidekick): upgrade block library to use new plugin #296

Closed helms-charity closed 7 months ago

helms-charity commented 11 months ago

Currently I've got a hard coded URL in the icons.js for testing purposes, I will change it before merging. The test URL should not be any different than on MAIN after I moved createOptimizedPicture function.

Issue

Fixes #239

Description

This is a new redo of the sidekick block library and SVG icon copier.

Test URLs

Testing Instruction

Currently I've got a hard coded URL in the icons.js for testing purposes, I will change it before merging. Use URL 239-sidekickupgrade--merative2--hlxsites.hlx.page/tools/sidekick/library.html to view the new sidekick.

The /block-library documents were all updated to render properly with a description of the variation on the bottom of the preview area.

To test blocks and sections, go to the HTML page and when you click on a block style, there's a button to copy it. You just have to paste this into a Word doc.

To test icons, choose "icons" from the top dropdown, then click on any SVG and it will copy the :icon-name: that you can paste into a document.

authoring

There's a new line in the metadata to add when you would like to copy compound sections. image

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/tools/sidekick/library.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/tools/sidekick/library.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

@helms-charity Is this PR ready for code and regression testing or are you still working on this feature?

helms-charity commented 11 months ago

It is ready for your QA and sign off, but you can't merge it until I put the $(host) variable back and whatever other linting it is complaining about.

helms-charity commented 11 months ago

@proeung no, the engineering team said they only created one option to copy page sections and they named it "blocks". When I asked about "what if I did blah blah blah" they told me that the core sidekick library code is still under development and that I should not go nuts with customization or I risk breaking it. They are rolling out the Templates option "very soon" I was told, maybe that will be a better place to put sections.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
helms-charity commented 11 months ago

P.s. authors can use the search at the top if that helps?

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

@helms-charity @keith-kaplan I have some follow-up questions for this new library upgrade and figured that it's probably better to discuss them on a call. I'll send out an invite. In the meantime, let's keep this PR as "on-hold".

helms-charity commented 11 months ago

@proeung ok, I have time before 4pm today or just about all day tomorrow available.

keith-kaplan commented 11 months ago

I can join too if that time works.

proeung commented 11 months ago

Notes from the 08/04 Review the new block library plugin + Doc management call

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 10 months ago

@helms-charity Just wanted to follow up on this PR to see if some of the feedback mentioned in this comment has been addressed (https://github.com/hlxsites/merative2/pull/296#issuecomment-1665769482).

helms-charity commented 10 months ago

I had to shift to another priority but I will be able to get back to this tomorrow. In the meantime I am asking when the Templates feature will be available too.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI