Closed helms-charity closed 7 months ago
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/tools/sidekick/library.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/tools/sidekick/library.html | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
@helms-charity Is this PR ready for code and regression testing or are you still working on this feature?
It is ready for your QA and sign off, but you can't merge it until I put the $(host) variable back and whatever other linting it is complaining about.
@proeung no, the engineering team said they only created one option to copy page sections and they named it "blocks". When I asked about "what if I did blah blah blah" they told me that the core sidekick library code is still under development and that I should not go nuts with customization or I risk breaking it. They are rolling out the Templates option "very soon" I was told, maybe that will be a better place to put sections.
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
P.s. authors can use the search at the top if that helps?
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
@helms-charity @keith-kaplan I have some follow-up questions for this new library upgrade and figured that it's probably better to discuss them on a call. I'll send out an invite. In the meantime, let's keep this PR as "on-hold".
@proeung ok, I have time before 4pm today or just about all day tomorrow available.
I can join too if that time works.
Notes from the 08/04 Review the new block library plugin + Doc management call
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
@helms-charity Just wanted to follow up on this PR to see if some of the feedback mentioned in this comment has been addressed (https://github.com/hlxsites/merative2/pull/296#issuecomment-1665769482).
I had to shift to another priority but I will be able to get back to this tomorrow. In the meantime I am asking when the Templates feature will be available too.
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/blog | ![]() |
Currently I've got a hard coded URL in the icons.js for testing purposes, I will change it before merging. The test URL should not be any different than on MAIN after I moved createOptimizedPicture function.
Issue
Fixes #239
Description
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/blogTesting Instruction
Currently I've got a hard coded URL in the icons.js for testing purposes, I will change it before merging. Use URL 239-sidekickupgrade--merative2--hlxsites.hlx.page/tools/sidekick/library.html to view the new sidekick.
The /block-library documents were all updated to render properly with a description of the variation on the bottom of the preview area.
To test blocks and sections, go to the HTML page and when you click on a block style, there's a button to copy it. You just have to paste this into a Word doc.
To test icons, choose "icons" from the top dropdown, then click on any SVG and it will copy the :icon-name: that you can paste into a document.
authoring
There's a new line in the metadata to add when you would like to copy compound sections.![image](https://github.com/hlxsites/merative2/assets/3883795/fe44f8ae-e617-4174-a36d-8ea27bc54564)