hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(content-band-list-block): Section content band list block. #299

Closed nimithshetty17 closed 1 year ago

nimithshetty17 commented 1 year ago

Issue

Fixes #MERATIVE-781

Description

This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. Sections > Section Content band list Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems.

New image

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

https://section-content-band-list--merative2--nimithshetty17.hlx.page/block-library/sections/section-content-band-list

Testing Instruction

To test the content band list and its responsiveness with respect to the design across all devices.

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 1 year ago

Checked, its good to go @nimithshetty17

CC: @proeung @keith-kaplan @helms-charity @sharathmrft @Shalini-SB

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 1 year ago

@proeung @keith-kaplan - I have made changes to the styles accordingly. Please have a look and let me know if there are any concerns.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/sections/section-content-band-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 1 year ago

@nimithshetty17 In an effort to move this ticket along. I'm gonna go ahead and take over this work. I'll assign you as one of the reviewers when it's ready.