hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(content-band-checkmarks): Content band checkmarks block changes #300

Closed nimithshetty17 closed 11 months ago

nimithshetty17 commented 11 months ago

Issue

Fixes #MERATIVE-780

Description

This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. for Section > Section Content band checkmarks. Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems.

New

image

Design Specs

https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1459-12919&mode=design&t=7UVLWpIfJsh1PJaS-0

Test URLs

https://section-content-band-checkmarks--merative2--nimithshetty17.hlx.page/block-library/sections/section-content-band-checkmarks

Testing Instruction

To test the content band checkmarks and its responsiveness with respect to the design across all devices.

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 11 months ago

In desktop, the width of the right side list rounded rectangles should be 360px. Rest is good to go.

image

@nimithshetty17 @sharathmrft @Shalini-SB @proeung

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

Marking this PR as "needs fixing", since video button functionality still needs to be implemented.

nimithshetty17 commented 11 months ago

@proeung - Had a word with Saad and once his PR for video player is reviewed and merged, I will use the same functionality for the video modal in content band checkmarks as well. @keith-kaplan @sahmad-merative @sharathmrft

proeung commented 11 months ago

@nimithshetty17 Okay, sounds good. Let's keep this PR as on-hold until this PR (https://github.com/hlxsites/merative2/pull/307) has been approved and merged.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 11 months ago

@sachinmesh - The width fix is added and can be reviewed.

sachinmesh commented 11 months ago

Ya, checked @nimithshetty17 , now the width on the lists is fixed. Thank you. Once the CTA is added its good to go. CC: @proeung

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

@nimithshetty17 This PR can be moved forward since this one (https://github.com/hlxsites/merative2/pull/307) has been merged.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 11 months ago

@sachinmesh @proeung @sharathmrft - The video player functionality has been implemented on section content band checkmarks.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/block-library/sections/section-content-band-checkmarks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI