hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(pdf-viewer): add mobile enhancements to PDF Viewer #302

Closed proeung closed 11 months ago

proeung commented 11 months ago

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-805

Description

Changed

Design Specs

Test URLs

Embed Mode: Inline without "Download PDF" button

Embed Mode: Full-Window/Default with "Download PDF" button

Testing Instruction

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/documents/case-study/health-insights-identify-savings-speciality-conditions PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/putra/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/documents/case-study/health-insights-identify-savings-speciality-conditions PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/putra/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/documents/case-study/health-insights-identify-savings-speciality-conditions PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/putra/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

@sharathmrft Thanks for testing this PR, however, I just wanted to note that Chrome mobile emulator within the desktop browser doesn't give a true representation of what the mobile experience will be like on actual devices, which explains why your screenshot doesn't have the PDF shown. I just tested the PDF Embed viewer without the download button on my mobile device and it renders correctly (see attached).

IMG_5509

On a different note, @keith-kaplan would you like me to merge these changes down or should we hold off until we confirm this update with Audrey & Caroline?

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/documents/case-study/health-insights-identify-savings-speciality-conditions PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/putra/payers-weight-loss-drugs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI