hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(thought-leadership): adjust the function that checks if a card has a specific attribute value #306

Closed proeung closed 11 months ago

proeung commented 11 months ago

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-812

Description

Changed

Design Specs

Test URLs

Screenshot 2023-08-01 at 4 11 08 PM

Testing Instruction

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/thought-leadership/health-insights?content-types=Success+stories PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/thought-leadership/health-insights?content-types=Success+stories PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/thought-leadership/health-insights?content-types=Success+stories PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/thought-leadership/health-insights?content-types=Success+stories PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sharathmrft commented 11 months ago

@proeung Can we have updated Query Index SharePoint to verify the display cards according to filters selection

@keith-kaplan @Shalini-SB

proeung commented 11 months ago

@sharathmrft Here's the query index (see link).

proeung commented 11 months ago

Merging, since we got approvals above.

@sharathmrft If you happen to notice any issues with how the cards are filtering. Please open up a follow-up ticket. If no issue arises, let a comment here.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/thought-leadership/health-insights?content-types=Success+stories PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI