hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(container): Adjust grid to align with design + adjust button hover effects #313

Closed proeung closed 10 months ago

proeung commented 11 months ago

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-787

Description

Changed

Design Specs

Test URLs

https://github.com/hlxsites/merative2/assets/1815714/e0e74ae1-deed-4921-929c-27f3c9333208

Testing Instruction

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 11 months ago

HI @proeung

Layout fluidity is good, hover animations are smooth, tab highlighter line animation is also great.

Some observations

  1. The scroll line is crossing the curve
image
  1. Layout at particular resolution the second heading crosses the curve see here
image
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 11 months ago

@sachinmesh Thanks for testing this PR! I've addressed the issues that you mentioned above, however, please note that 1199px is just a size in between tablet 768px and desktop 1200px. The text/heading container is going to resize and sits slightly within the white curve.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aavilamer commented 10 months ago

@proeung this looks great! So happy to see this come to life.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI