Closed proeung closed 10 months ago
aem-code-sync[bot]
commented
10 months ago Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/leverage-real-world-data-in-the-cloud |     |
     |
 |
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact |   |
   |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud |  |
   |
|
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact | |
  |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud | |
|
|
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact |  |
    |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud |  |
    |
|
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact |  |
  |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud | |
  |
|
proeung
commented
10 months ago @sachinmesh @sharathmrft I pushed up some commits that should addressed both of your feedback, however, there are a few I want to quickly note as not being an issue.
- Spacing between social icons and divider line above it should be 26px and not 32px.
@sachinmesh 26px is not a consistent spacing value that I see within our spacing guideline. For this area, I'm going to keep it at 24px and let's update this in the design pattern library as well.
Spacing above speaker title should be 80px. and below should be 24px.
@sachinmesh The 80px is only relevant when there's a bullet list which has a bottom spacing of 16px as seen in the design specs. The spacing on the top should keep to 64px for the h3 title padding top.
Read more Read less is missing
We need to refactor the way the current Read More/Less functionality as it only accounts for use cases when there's just a single .default-content-wrapper and not the whole body text column area. Let's follow up in a separate ticket.
@keith-kaplan The changes in this PR requires some content entry update for pages that are using the Marketo form. Would it be good for us to do a content working session update together so that we publish changes right as this PR is merged? Let me know what you think.
sachinmesh
commented
10 months ago 1. Sorry, typo error here for 26px, it should be 16px.
2. On Mobile, the eyebrow font style should be 11px Alliance no.1 medium
Rest is good to go.
@proeung @sharathmrft
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact |  |
  |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud |  |
 |
|
proeung
commented
10 months ago @sachinmesh I just pushed up a commit that should address your latest comment. Can you take a look again?
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact | |
 |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud |  |
  |
|
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact |   |
 |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud | |
  |
|
proeung
commented
10 months ago @keith-kaplan Thanks for testing this PR! I just pushed up fixes for the form title issue you mentioned. Please see links below for the content entry changes.
sharathmrft
commented
10 months ago @proeung I have retested fixed issues commented by me those are fine. @keith-kaplan @sachinmesh
keith-kaplan
commented
10 months ago @proeung when i author the webpage with the text sidebar on the right side and the H2 is removed from the word doc, it looks like the anchor link down to this section won't work. Even by adding #registration into the link field in word doesn't seem like it thinks that is a real link. Video posted in Teams. It was too large to upload here.
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact | |
 |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud |  |
  |
|
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact | |
 |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud |  |
   |
|
aem-code-sync[bot]
commented
10 months ago | Page | Scores | Audits | |
|---|---|---|---|
| /drafts/putra/contact | |
 |
|
| /drafts/putra/leverage-real-world-data-in-the-cloud | |
|
|
proeung
commented
10 months ago @keith-kaplan I just pushed up some commits for the changes that we discussed on the call this morning. Also, I add a fix to the radio input display issue on mobile devices. I tested this on my iOS and it looks good (see attached), but would be good to have you test it as well. Let me know if you see anything odd.
Preview: https://feat-headshot-list-774--merative2--proeung.hlx.page/drafts/putra/ism-2023
keith-kaplan
commented
10 months ago Great. I'll start updating the other pages with this styling.
proeung
commented
10 months ago @keith-kaplan Thanks for helping with updating the doc structure for these pages. Since everything looks good, I'm going to merge the changes in this PR.
Issue
Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-774 and https://jira.sdlc.merative.com/browse/MERATIVE-859
Description
New
headshot-listthat acts as a content fragment, querying thepeople/query-index.jsonand pulling in the metadata needed to display the author's information in the headshot list pattern.Changed
Content Author Changes
Authors and contributors for some of the Events/Webinar will need to be moved into the
/peopledirectory within our SharePoint folder.We'll need to adjust the SharePoint doc structure to account for the metadata section for Webinar pages where the Marketo form is located on the left-hand side and other contacts pages where it's displayed on the right column.
@keith-kaplan @scottbridgeman We'll need to update the existing pages where Marketo is being used so that they're using the proper metadata classes (see below).
Regular content body with two columns (Left Col: Text/Body) | (Left Col: Marketo Form)
Regular content body with two columns (Left Col: Marketo Form) | (Left Col: Text/Body)
Design Specs
Test URLs
main): https://main--merative2--hlxsites.hlx.page/drafts/putra/leverage-real-world-data-in-the-cloudTesting Instruction
/peopledirectory. https://feat-headshot-list-774--merative2--proeung.hlx.page/drafts/putra/leverage-real-world-data-in-the-cloud