hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(notification): Added notification block #317

Closed sahmad-merative closed 1 year ago

sahmad-merative commented 1 year ago

Description

This ticket is part of the phase 3 effort, which is to migrate all of the remaining components/patterns in AEM over to Franklin. See EPIC for more detail (MERATIVE-765) Block > Notification Note: part of this work is to clean up the naming in Franklin to ensure it aligns with our Design Systems. New

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Testing Instruction

Notification block can be added to the page as shown in the sharepoint link below.

https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/Doc.aspx?sourcedoc=%7B07BBC79A-1D9E-4B72-B1BF-BAE1AAAB22D7%7D&file=notification.docx&action=default&mobileredirect=true

image
aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 1 year ago

All bugs fixed. Thank you.

@proeung @sahmad-merative

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/block-library/templates/notification PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI