hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feature(stats-bar): Added statsbar block #320

Closed sahmad-merative closed 10 months ago

sahmad-merative commented 10 months ago

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Testing Instruction

image

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

aem-code-sync[bot] commented 10 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/templates/statsbar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sharathmrft commented 10 months ago

@sahmad-merative No divider in between each block at the top horizontal line screen shot attached here. image

@proeung

sachinmesh commented 10 months ago
  1. On desktop, this should be Alliance no.116px regular and not light.
  2. Spacing below the inline link CTA and divider line should be 64px and not 48px.
image
  1. The stat block should be of 216px wide

    image
  2. Againon tablet and mobile the font style should be regular and not light.

    image

CC: @proeung @sahmad-merative @sharathmrft

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/sections/section-stats-bar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 10 months ago

@sahmad-merative Looks like there are some merge conflicts coming from main. Once, these conflicts have been resolved, I'll approve and merge your PR.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/sections/section-stats-bar PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI