hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feature(case-study-carousel): Case study carousel block. #323

Closed nimithshetty17 closed 10 months ago

nimithshetty17 commented 10 months ago

Issue

Fixes #MERATIVE-785

Description

There's already a block in Franklin called "Carousel". This will be a variation called "Carousel - Case Study".

New

image

Design Specs

Test URLs

Testing Instruction

To test the case study carousel and its responsiveness with respect to the design across all devices.

aem-code-sync[bot] commented 10 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 10 months ago

@sachinmesh - The requested changes have been committed. Please have a look. cc: @proeung @Shalini-SB @keith-kaplan

sachinmesh commented 10 months ago

Checking the link here. https://case-study-carousel--merative2--nimithshetty17.hlx.page/block-library/blocks/carousel

HI @nimithshetty17 Can't see the changes in the above link, can you share the correct link.

Changes pending are

  1. In desktop, eyebrow font style should be 14px Alliance No.1 medium and not 16px.
image
  1. Title Text box should be 268px wide
image
  1. Body text box should be 446px wide.
image
  1. Spacing between side arrows with above and below component's should be 48px.
image
  1. Carousal indicators spacing with carousal card should be 64px.
image
nimithshetty17 commented 10 months ago

@sachinmesh I have cleared the cache. Please check in an incognito window now.

sachinmesh commented 10 months ago

CHecked @nimithshetty17

Rest is good, but the carousal arrows are gone, can you check once.

image image
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 10 months ago

@sachinmesh have added the arrows back.

sachinmesh commented 10 months ago

Good to go @nimithshetty17 @proeung @sharathmrft

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 10 months ago

@proeung @sachinmesh have done the requested changes. Please have a look.

sachinmesh commented 10 months ago

Good to go now with 100 x 100 carousal arrow.

@nimithshetty17 @proeung

helms-charity commented 10 months ago

@nimithshetty17 @proeung ".carousel-slide-container" is not getting the calculated height, so it is presenting at 0 height. (when you put some number in the browser console, the content shows). I'll see if I can find what happened.

image

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/block-library/blocks/carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 10 months ago

@proeung - Testimonal carousel issue is fixed now.