Closed sahmad-merative closed 1 year ago
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/privacy |
@proeung - one question on the solution here and happy to talk through this if that's easier.
Just wondering about the URL structures. Please note: This is a true nit and I might be too picky on this one.
I noticed that the URL structure for the uses a #bookmark# - should we be using the bookmark number or the common section name in Word? I'm not sure if Franklin would allow for this, but it did jump out at me. Again, this is a nit and I'm not sure how the rest of the team would have the same feedback.
Happy to discuss if that's easier
vs.
Page | Scores | Audits | |
---|---|---|---|
/privacy |
@scottbridgeman Thanks for the review and great question!
I noticed that the URL structure for the uses a #bookmark# - should we be using the bookmark number or the common section name in Word? I'm not sure if Franklin would allow for this, but it did jump out at me. Again, this is a nit and I'm not sure how the rest of the team would have the same feedback.
The #
or anchor link should be pulled from the string of the Headline (eg. /privacy#children). I would double-check the hyperlink of the doc which has more options on the desktop app (see attached).
Page | Scores | Audits | |
---|---|---|---|
/privacy |
@proeung if you use the full URL with the hash, I believe that will turn into the anchor link you want to use.
@helms-charity That's good to know, thanks! @scottbridgeman we might need to adjust the hyperlink setting of each link to include the full URL path as Charity mentioned above. In the meantime, I'm going to merge the changes in this PR and publish the existing changes made to this Privacy page (https://main--merative2--hlxsites.hlx.page/privacy) so that the error in the console is fixed via this PR.
@proeung - Perfect, thank you.
Fixes #MERATIVE-860
Description
Added a table of contents with anchor links that jump down to each section in the page.
Adjusted offset position to align with column heading
Design Specs
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/privacyTesting Instruction
Franklin doc : https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/Doc.aspx?sourcedoc=%7B9a6326f1-8a50-461d-be6f-98bdf34d4a0a%7D&action=edit&wdPid=7612f173