hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

chore(csp): enable google doubleclick in img-src #325

Closed proeung closed 10 months ago

proeung commented 10 months ago

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-869

Description

Changed

Design Specs

Test URLs

Testing Instruction

aem-code-sync[bot] commented 10 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/thank-you PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
scottbridgeman commented 10 months ago

@proeung - When I tried to the form, https://chore-csp-869--merative2--proeung.hlx.page/contact, it passed me to the production server and blocked the event. We may have to update the CSP on the live server and re-test. Unless you have other ideas on how we might be able to test this. Totally trust your expertise here :-)

proeung commented 10 months ago

@scottbridgeman I don't know if something got changed, but I'm no longer seeing doubleclick error in the console log here (https://chore-csp-869--merative2--proeung.hlx.page/thank-you). I think we can try and merge the changes and see if anything else comes up on the main/live domain name side.

scottbridgeman commented 10 months ago

Thank you, @proeung - I will monitor Google Analytics to see if any events are firing/being captured.