Closed proeung closed 1 year ago
aem-code-sync[bot]
commented
1 year ago Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /block-library/blocks/accordion |     |
     |
 |
| /block-library/blocks/content-intro |  |
  |
|
| /block-library/blocks/linkable-cards | |
   |
|
| /block-library/blocks/stat-with-illustration |  |
Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) | |
| /clinical-decision-support |    |
     |
|
aem-code-sync[bot]
commented
1 year ago | Page | Scores | Audits | |
|---|---|---|---|
| /block-library/blocks/accordion | |
 |
|
| /block-library/blocks/content-intro | |
|
|
| /block-library/blocks/linkable-cards |  |
  |
|
| /block-library/blocks/stat-with-illustration | |
Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) | |
| /clinical-decision-support |  |
   |
|
aem-code-sync[bot]
commented
1 year ago aem-code-sync[bot]
commented
1 year ago 
proeung
commented
1 year ago @sachinmesh Can I get design QA for this PR?
aem-code-sync[bot]
commented
1 year ago aem-code-sync[bot]
commented
1 year ago 
keith-kaplan
commented
1 year ago @proeung a few comments.
Accordion example - https://fix-822-product-landing-issues--merative2--proeung.hlx.page/events/2023-zelta-user-conference. It looks like this block is not affected by lacking the new theme metadata attribute.
proeung
commented
1 year ago @keith-kaplan Thanks for taking a look at this PR. Please see my response below.
On CDS page for accordion, the title should be H2 vs H3. I changed here - https://fix-822-product-landing-issues--merative2--proeung.hlx.page/clinical-decision-support (Get to know our capabilities)
Good point! I'll adjust the CSS to ensure that we're applying the proper headline styling to H2 instead of H3. I'll push up a commit for this.
Video resources card needs to open in light box vs linking off to youtube. Can this be solved in the other Jira issue being worked on?
Yep! This feature will be addressed in this ticket (https://jira.sdlc.merative.com/browse/MERATIVE-858). A separate PR will be opened up for this.
Can we confirm the difference in section divider with these items? Divider vs Divider (layout). It looks like they are both using inline code, but it seems one divider is gradient. I see both use the no-pad class in the metadata table.
Yeah, ideally these dividers should be handled as a block where we can set the style of the divider (eg. regular bone, gradient, etc). I can try and clean it up in this PR as well, but if not, we can follow up with a seperate ticket to improve the management of the divider line.
sharathmrft
commented
1 year ago @proeung Video resources card modal popup goes off as shown below.
aem-code-sync[bot]
commented
1 year ago proeung
commented
1 year ago @sharathmrft @sachinmesh I just pushed up a commit that should address majority of your feedback.
Link is not properly aligned screenshot is attached below
Fixed
Video resources card modal popup goes off as shown below.
This feature will be addressed in this ticket (https://jira.sdlc.merative.com/browse/MERATIVE-858). A separate PR will be opened up for this.
Padding between heading and description should be 32px and not 48px.
Fixed
Padding between the description and the questions should be 48px.
Fixed
Font style for description should be 21px. see the figma link for revamped MDX design https://www.figma.com/file/FSqQ1LYrVSssEFOZuOnMIE/Final-page-layouts-for-Merative.com?type=design&node-id=2693-15913&mode=design&t=88QCgXZUgqm4tMpJ-4
@sachinmesh This spec doesn't align with the Accordion pattern design specs that are in our design system, which has the description at 16px (see - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1459%3A19121&mode=design&t=003mQGakUdFWhOL9-1). Can you touch base with Ana to verify which specs is correct?
aem-code-sync[bot]
commented
1 year ago aem-code-sync[bot]
commented
1 year ago aem-code-sync[bot]
commented
1 year ago proeung
commented
1 year ago @keith-kaplan Thanks for the review/approval! Merging PR so that we can move forward with the campaign landing page (https://fix-822-product-landing-issues--merative2--proeung.hlx.page/campaigns/curam/missouri) and this overall design QA ticket (https://jira.sdlc.merative.com/browse/MERATIVE-880).
Issue
Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-822
Description
/clinical-decision-support) version within Franklin.New
Changed
Removed
Content Band Checkmarkblock and merged it to theContent Introblock instead. This change helps consolidate code (CSS and JS), removes duplications, and creates consistency. FYI. @nimithshetty17content-band-checkmarks/content-band-checkmarks.jscontent-band-checkmarks/content-band-checkmarks.cssDesign Specs
Test URLs
main): https://main--merative2--hlxsites.hlx.page/clinical-decision-supportTesting Instruction