hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(breadcrumb): Add breadcrumb block fragment #330

Closed proeung closed 9 months ago

proeung commented 10 months ago

Issue

Fixes https://jira.sdlc.merative.com/browse/MERATIVE-790

Description

New

Screenshot 2023-09-06 at 4 26 49 PM

Screenshot 2023-09-06 at 4 27 43 PM

Design Specs

Test URLs

MDX Sub Product page with a breadcrumb

Screenshot 2023-09-06 at 4 39 09 PM

Curam Contact page without the brand logo in the breadcrumb

Screenshot 2023-09-06 at 4 39 21 PM

Testing Instruction

aem-code-sync[bot] commented 10 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 10 months ago

@keith-kaplan @scottbridgeman Just a heads up, I've updated some of the contact/offer pages with the breadcrumb and brand leadspace that we outlined in the design (see - Figma Link). Feel free to edit and publish the changes once this PR has been tested and merged.

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 10 months ago

@sachinmesh Thanks for conducting design QA for this PR. I just pushed up a commit that should address all of your feedback. Can you take a look?

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 10 months ago

@sharathmrft @sachinmesh Thanks for the review! I just pushed up a commit that adds the ellipsis, similar to what we have right now in AEM. Please take a look again.

Screenshot 2023-09-11 at 11 15 46 AM

aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sharathmrft commented 9 months ago

@proeung Looks good to me @sachinmesh

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
keith-kaplan commented 9 months ago

@proeung here are two more pages to include in this https://www.merative.com/offers/contact-micromedex https://www.merative.com/offers/contact-zelta

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/clinical-decision-support/pharmacy-inventory-management PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/offers/contact-curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI