hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(content-intro): add stat number style #337

Closed proeung closed 9 months ago

proeung commented 9 months ago

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-889

Description

Changes

Design Specs

Test URLs

Screenshot 2023-09-13 at 3 46 24 PM

Screenshot 2023-09-13 at 3 46 43 PM

Testing Instruction

aem-code-sync[bot] commented 9 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 9 months ago

@sachinmesh It doesn't look to me like the specs of the "Single Stat" component listed in the DS are correct. The specs should be the same as the single stat used on the homepage (see attached), which this Content Intro block is in alignment with.

Can you update the Figma file to align with the specs we have in the code?

Screenshot 2023-09-14 at 12 26 38 PM

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 9 months ago

Thats also wrong @proeung on homepage. here in our designs in final layouts we have https://www.figma.com/file/FSqQ1LYrVSssEFOZuOnMIE/Final-page-layouts-for-Merative.com?type=design&node-id=428-43582&mode=design&t=sOkcQbdTkDQdU7uE-4

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 9 months ago

@sachinmesh I just pushed up a commit that should keep the spacing of the "Single Stat" component consistent on both the homepage and /real-world-evidence. Can you take a look again?

Also, there's a discrepancy in our Figma final pages project where the top gradient line should be expanded for the full width similar to the component above (see attached). Let's fix this in Figma.

Screenshot 2023-09-15 at 10 02 15 AM

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/real-world-evidence PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
anabarcelona commented 9 months ago

Hi @sachinmesh and @proeung are you asking what the breakpoints should be for when we use a solo stat?

https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=342%3A2432&mode=design&t=Vqv9JlbHeUqIfMzg-1

Single stat in UI Elements...

anabarcelona commented 9 months ago

Hi @sachinmesh I reviewed this with Putra and left a comment for you in Figma. Let me know if you have any questions...