hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(masthead): Updated Mega-menu to support "Support page" links #338

Closed sahmad-merative closed 9 months ago

sahmad-merative commented 9 months ago

The purpose of updating the Masthead/Nav Megamenu is to streamline the display of the Support links so that they're easily accessible within the menu.

This PR is only for Frankiln implementation.

Issue MERATIVE-872

Fixes #

Description

The purpose of updating the Masthead/Nav Megamenu is to streamline the display of the Support links so that they're easily accessible within the menu.

This PR is only for Frankiln implementation.

New

Updated Mega-menu to support "Support page" links

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Testing Instruction

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

aem-code-sync[bot] commented 9 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 9 months ago

Everything looks good, fonts, icons at all brakpoints. only the alignment here is wrong @proeung

image

The layput is wrong here

image

The logo side should be of 336px and what is curam side 336px with 71px padding

image
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sahmad-merative commented 9 months ago

@sahmad-merative LGTM! Once, the data source has been changed back to the default fragments path, I'll go ahead and merge this PR down.

I am waiting for @sharathmrft to complete testing and approve. Once that is done I'll revert back to default fragment path.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sahmad-merative commented 9 months ago

@proeung The data source has been changed back to the default fragments path, and all the lint issues are also resolved. This PR is ready to be merged.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI