Closed nimithshetty17 closed 9 months ago
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/block-library/buttons/buttons-all |
Page | Scores | Audits | |
---|---|---|---|
/block-library/buttons/buttons-all |
Page | Scores | Audits | |
---|---|---|---|
/block-library/buttons/buttons-all |
Issue Fixes #MERATIVE-858
Description We need to ensure that all of the button styles (e.g.. Primary, Secondary, Tertiary) (see - https://main--merative2--hlxsites.hlx.page/block-library/buttons/buttons-video) can support video modal when the href is defined as a video type.
Changed
Figma Link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=272-62&mode=design&t=AV0llNTB4XL0rh71-0 Test URLs Before (Changes from main): https://main--merative2--nimithshetty17.hlx.page/block-library/buttons/buttons-all After (Changes from this PR): https://global-cta-modal-implementation--merative2--nimithshetty17.hlx.page/block-library/buttons/buttons-all Testing Instruction To test if the video player is opening a modal for all the button and link styles.