hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(support-landing): add Short Cards and Content Text Body blocks #340

Closed proeung closed 9 months ago

proeung commented 9 months ago

Issue

Fixes https://jira.sdlc.merative.com/browse/MERATIVE-893 and https://jira.sdlc.merative.com/browse/MERATIVE-894

Description

New

Design Specs

Test URLs

Support Hub Landing

Screenshot 2023-09-20 at 2 52 29 PM

Product Support Landing

Screenshot 2023-09-20 at 2 51 54 PM

Product Support Landing

Testing Instruction

aem-code-sync[bot] commented 9 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 9 months ago

@sachinmesh @sharathmrft See my response to your feedback below.

On desktop, vertical padding between cards should be 48px

This is a mistake and one that @anabarcelona has already fixed in Figma. The gap is 24px for both variations (Short Cards with Logos and Graphics)

On product support, Caret issue in tab and mobile.

Fixed

Issue when resizing from mobile to tab to desktop. Could be cache memory issue.

Not able to replicate this issue. Sounds like a memory issue within your computer and not so much from the site.

Alignment issue of cards in Tab/mobile. They should be inline with the heading.

Fixed

Padding issues on right side on tablet and mobile in below the cards

Fixed

1.'Other products' icon is deferent than the design

Updated the icon

2.Short cards all are not displaying in one shot in tab view these are horizontally placed

This is part of the design specs where the "Short Cards with Graphics" turns into horizontal scroll on tablet and mobile breakpoints.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI