hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

feat(microsite): Add Solution Header and Solution Footer blocks used within custom campaign/microsites #344

Closed proeung closed 9 months ago

proeung commented 9 months ago

Issue

Fixes https://merative.atlassian.net/browse/MERATIVE-878 & https://merative.atlassian.net/browse/MERATIVE-879

Description

New

Changed

Design Specs

Test URLs

Testing Instruction

Screenshot 2023-09-29 at 11 44 38 AM Screenshot 2023-09-29 at 11 44 55 AM Screenshot 2023-09-29 at 11 44 44 AM

aem-code-sync[bot] commented 9 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 9 months ago

@sachinmesh I just pushed up a commit to address some of the spacing and logo size issues that you mentioned above.

As for the height of the borderline on the sticky nav scroll and the gradient on the scroll, let's discuss that on our next design call. I have some concerns about the feasibility given the current timeline and dev resources.

cc: @aavilamer

https://javascript.plainenglish.io/how-to-create-horizontal-vertical-scroll-shadows-26aa7a7f00a0

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
proeung commented 9 months ago

@keith-kaplan Great! Just need @sachinmesh to re-review/approve and this PR is ready for merge unless there are additional changes.