search

hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

fix(duplicate-entries): removed duplicate entries #345

Closed sahmad-merative closed 9 months ago

sahmad-merative commented 9 months ago

Issue

Fixes MERATIVE-897

Description

We're seeing duplicate topic names within the Blog filtering page (/blog). This is happening because Content Authors are not using consistent sentence cases for Topics that they're adding to Sharepoint. This is largely due to the nature of Franklin where the tagging/taxonomy is associated by the string name instead of a UID.

Changed Adjusted the script for comparing the topic string/value and standardize the value to sentence case so that we can consistent filtering.

Design Specs N/A

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Testing Instruction

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

aem-code-sync[bot] commented 9 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sahmad-merative commented 9 months ago

@sahmad-merative First letter should be in Caps image @proeung @sachinmesh

@proeung I believe the best approach to address this issue is to handle it at the content level. In my perspective, implementing font transformations through code may not be advisable, as it could inadvertently convert words that should remain in all uppercase to lowercase.

For instance, consider the text "HEOR" (as depicted in the screenshot below), which, when subjected to code-driven font transformation, might unintentionally become "Heor".

Similarly, if there are names or acronyms like "SPM," they could inadvertently be converted to all lowercase as well.

Screenshot 2023-09-28 at 6 16 30 PM

CC: @sharathmrft @sachinmesh @keith-kaplan

proeung commented 9 months ago

Adding myself as the assignee to this PR so that I can pick up this work since Saad is no longer on the project.

aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
keith-kaplan commented 9 months ago

This looks good. @nimithshetty17 are you able to approve this?