hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

Creation of a solution block. #350

Closed nimithshetty17 closed 8 months ago

nimithshetty17 commented 8 months ago

Fixes #MERATIVE-886

Description

The current name in Franklin for this block is a Teaser List and it only renders if a link is added for each item. We want to make this so it allows for authors to use this layout without links for each item

New

image

Changed

image

Test URLs

aem-code-sync[bot] commented 8 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sachinmesh commented 8 months ago

Extra 160px can be seen below the cards @nimithshetty17

image
keith-kaplan commented 8 months ago

@nimithshetty17 @sachinmesh please see uses of the solution block in actual pages as well. See here:

https://solution-list-block-new--merative2--nimithshetty17.hlx.page/curam

sachinmesh commented 8 months ago

https://solution-list-block-new--merative2--nimithshetty17.hlx.page/curam

This looks good to me

keith-kaplan commented 8 months ago

@nimithshetty17 @sachinmesh I was looking at another page and it looks like there maybe a regression with the latest version. please take a look at screenshot -

image

https://solution-list-block-new--merative2--nimithshetty17.hlx.page/real-world-evidence

sachinmesh commented 8 months ago

Hi @nimithshetty17 , most of the component, the 160px padding is absent. CC: @keith-kaplan

  1. There should not be any divider line here
image
  1. Here, a margin of 160px should be given above the divider line.

    image
  2. Below the illustration 160px margin is needed in bone color.

    image
  3. Again, 160px margin is gone here

    image
  4. Again here, below the simple content component and the ready to talk CTA 160px margin is absent.

image
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 8 months ago

@sachinmesh @keith-kaplan - The fix for the above mentioned comments have been added.

sachinmesh commented 8 months ago
  1. Background color of flexible component should be white and not bone.
image
  1. The margin below the illustration should be 160px.
image

@nimithshetty17 @keith-kaplan