hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

Curam missouri microsite page fixes. #353

Closed nimithshetty17 closed 8 months ago

nimithshetty17 commented 8 months ago

Issue

Fixes #MERATIVE-905

Description

The latest designs for the Missouri campaign in microsite do not match the updated designs in Figma. It is mostly background color changes and addition of headline. The PR consists of fixes for that.

Test URLs

Testing Instruction

To test the changes as per the figma link provided above.

aem-code-sync[bot] commented 8 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 8 months ago

@anabarcelona @sachinmesh @keith-kaplan - These are the following issues addressed in the latest commit:-

  1. Increase title to H1 ” Explore our platform” - Code side changes have been done, authoring side changes are pending.
  2. Make sure space between H2 and first feature is 96px.
  3. Remove bottom gray rule below the navigation bar- same update for mobile.
  4. Reduce the space above full width image and below the list. It should be 96px.
anabarcelona commented 8 months ago

Hi @nimithshetty17, updated and added comments in the QA doc: https://merative-my.sharepoint.com/:w:/p/abarcelona/EZLyhr7AsFBOuh-jptVHz4MBlMXA7ftxXnnF_viNr2WH8w?e=WaTod4

Happy to review together next time we meet. It's looking good!

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 8 months ago

@anabarcelona @keith-kaplan @sachinmesh - Please find the fixes for the new commit below:-

  1. Reduce the space above full width image and below the list. It should be 96px -Done
  2. When you scroll down to the case studies, can the nav slide over to show Case studies is highlighted? -Done
  3. “Why Curam” shouldn’t be selected when you are in the platform area of the page. -Done.
  4. Currently it’s not aligning to our gutters -Done
  5. Remove bottom gray border fro mobile and tablet. Please add that back for Desktop only -Done
  6. we still need to increase the size of Explore our platform title to 64px -Done
anabarcelona commented 8 months ago

Thank @nimithshetty17, I've reviewed and marked things as done! Some are still some remaining things on the list. Thank you :)

https://merative-my.sharepoint.com/:w:/p/abarcelona/EZLyhr7AsFBOuh-jptVHz4MBlMXA7ftxXnnF_viNr2WH8w?e=al9pDN****

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 8 months ago

@anabarcelona @sachinmesh - The following comments are addressed in the latest commit:-

  1. On mobile & tablet the divider line needs to be full bleed off to the left and right. I’m seeing a bit of space there. Please remove on mobile and tablet.
  2. “Why Curam” shouldn’t be selected when you are in the platform area of the page.
  3. When you scroll down to the case studies, can the nav slide over to show Case studies is highlighted? Right now it’s getting cut off.
  4. Make sure we include the gradient to the left and right of the nav items- both on light and dark backgrounds.
anabarcelona commented 8 months ago

Thanks Nimith once again! We are so close... there are 3 open tasks still remaining in the doc...

nimithshetty17 commented 8 months ago

@anabarcelona @sachinmesh - These are the pending changes and the fixes are added in the latest commit:-

  1. Adjust the gradient for 25+
  2. The only title that needs to be our H1 size is the “Explore the platform” title, please adjust.
  3. The arrow buttons fill needs to be in bone. Currently they are filled with white. Please update. Rest which are not marked as Done is:-
  4. Remove bottom gray rule below the navigation bar- same update for mobile please. The line needs to be there on desktop. It’s no longer there. Please add that back for Desktop only. See screenshot below- bottom rule divider is missing on desktop. (Discussed with Sachin he said it is reflecting)
  5. Update the artwork to match the design. (Authoring change)
  6. Please make the phone number a link... on mobile it should call the number. (Authoring change)
anabarcelona commented 8 months ago

@nimithshetty17 question on #5 above... who exports the artwork? And where is it saved for the content authors to upload it?

anabarcelona commented 8 months ago

All the other updates you mentioned above look good! Thanks @nimithshetty17

nimithshetty17 commented 8 months ago

@nimithshetty17 question on #5 above... who exports the artwork? And where is it saved for the content authors to upload it?

@anabarcelona - We usually get it from Sachin and then the content author will drop the image in the word document.

anabarcelona commented 8 months ago

@nimithshetty17, okay, sounds like I need to export them and save them. Where are they usually saved? Thank you!

nimithshetty17 commented 8 months ago

@nimithshetty17, okay, sounds like I need to export them and save them. Where are they usually saved? Thank you!

@anabarcelona - We don't save the images anywhere in Franklin. You can upload it in the Jira ticket or mail it, we'll replace the image.

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI