Closed nimithshetty17 closed 8 months ago
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
@anabarcelona @sachinmesh @keith-kaplan - These are the following issues addressed in the latest commit:-
Hi @nimithshetty17, updated and added comments in the QA doc: https://merative-my.sharepoint.com/:w:/p/abarcelona/EZLyhr7AsFBOuh-jptVHz4MBlMXA7ftxXnnF_viNr2WH8w?e=WaTod4
Happy to review together next time we meet. It's looking good!
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
@anabarcelona @keith-kaplan @sachinmesh - Please find the fixes for the new commit below:-
Thank @nimithshetty17, I've reviewed and marked things as done! Some are still some remaining things on the list. Thank you :)
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
@anabarcelona @sachinmesh - The following comments are addressed in the latest commit:-
Thanks Nimith once again! We are so close... there are 3 open tasks still remaining in the doc...
@anabarcelona @sachinmesh - These are the pending changes and the fixes are added in the latest commit:-
@nimithshetty17 question on #5 above... who exports the artwork? And where is it saved for the content authors to upload it?
All the other updates you mentioned above look good! Thanks @nimithshetty17
@nimithshetty17 question on #5 above... who exports the artwork? And where is it saved for the content authors to upload it?
@anabarcelona - We usually get it from Sachin and then the content author will drop the image in the word document.
@nimithshetty17, okay, sounds like I need to export them and save them. Where are they usually saved? Thank you!
@nimithshetty17, okay, sounds like I need to export them and save them. Where are they usually saved? Thank you!
@anabarcelona - We don't save the images anywhere in Franklin. You can upload it in the Jira ticket or mail it, we'll replace the image.
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
Page | Scores | Audits | |
---|---|---|---|
/drafts/putra/campaigns/missouri |
Issue
Fixes #MERATIVE-905
Description
The latest designs for the Missouri campaign in microsite do not match the updated designs in Figma. It is mostly background color changes and addition of headline. The PR consists of fixes for that.
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/drafts/putra/campaigns/missouriTesting Instruction
To test the changes as per the figma link provided above.