Navattic page blocks. - Githubissues

nimithshetty17 commented 7 months ago

Issue

Description

This is a request made to improve/optimize the user experience of the Navattic demo The demo page template currently lives within AEM, however, it needs to be moved into Franklin as part of the phase 3 migration effort.

Figma Link - https://www.figma.com/file/9THM4wHxEECVNzFpjuZZre/Navattic-Demo?type=design&node-id=767-8217&mode=design&t=DoD9UkeRkgughMDP-0

Test URLs

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/drafts/nimith/navattic-page
After (Changes from this PR): https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/drafts/nimith/navattic-updated

aem-code-sync[bot] commented 7 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

[ ] Re-run PSI Checks

aem-code-sync[bot] commented 7 months ago

Page	Scores	Audits	Google
/drafts/nimith/navattic-page		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404)

aem-code-sync[bot] commented 7 months ago

Page	Scores	Audits	Google
/drafts/nimith/navattic-page		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404)

aem-code-sync[bot] commented 7 months ago

Page	Scores	Audits	Google
/drafts/nimith/navattic-page

keith-kaplan commented 7 months ago

@nimithshetty17 let's make the footer for the demos a Fragment since that shouldn't be changed by an author.

aem-code-sync[bot] commented 7 months ago

Page	Scores	Audits	Google
/drafts/nimith/navattic-page

aem-code-sync[bot] commented 7 months ago

Page	Scores	Audits	Google
/drafts/nimith/navattic-page

nimithshetty17 commented 7 months ago

@keith-kaplan have created and added two fragments for the footer from the approach Charity had suggested and they can be viewed here:- https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/drafts/nimith/navattic-updated. Let me know if this is the expected approach.

aem-code-sync[bot] commented 7 months ago

Page	Scores	Audits	Google
/drafts/nimith/navattic-updated

nimithshetty17 commented 7 months ago

@sachinmesh the below issues are addressed:-

Horizontal product logo text is missing. - Fixed
The divider line color should be Neutral 140 i.e. 5C5A57 - Fixed
Hamburger menu is missing on mobile. - Fixed
Footer font style on mobile should be 14px light - Fixed

Please have a look and let me know if there are more.

keith-kaplan commented 7 months ago

@nimithshetty17 I created another demo for Micromedex and just saw that the CTA styling is broken when only using on button. Can we make sure the formatting is still correct even if one CTA is present?

https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/clinical-decision-support/demo

nimithshetty17 commented 7 months ago

@nimithshetty17 I created another demo for Micromedex and just saw that the CTA styling is broken when only using on button. Can we make sure the formatting is still correct even if one CTA is present?

https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/clinical-decision-support/demo

@keith-kaplan for solution it has to be authored by adding a field called CTA and the buttons below. Please check https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/clinical-decision-support/demo.