hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

Stat with illustration padding issue #363

Closed nimithshetty17 closed 6 months ago

nimithshetty17 commented 7 months ago

Fixes MERATIVE-950

Description

The stat with illustration block was designed to only have an image below it. We would like to update this block to ensure there is the proper padding added above/below when an image is not present.

Test URLs

aem-code-sync[bot] commented 7 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 7 months ago
Page Scores Audits Google
/drafts/Keith/real-world-evidence-copy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 7 months ago

@keith-kaplan have added the bottom padding. Let me know if this is ok.

nimithshetty17 commented 7 months ago

@keith-kaplan have added a block with stat-with-illustration(no-padding) to add an optional padding. Let me know if this is ok. Can be reviewed here:- https://main--merative2--nimithshetty17.hlx.page/block-library/blocks/stat-with-illustration

keith-kaplan commented 7 months ago

I do not see the no-padding on top working. Can you check?

image

nimithshetty17 commented 7 months ago

@keith-kaplan sorry I copied the wrong url here. This is the right url:-https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/block-library/blocks/stat-with-illustration

keith-kaplan commented 7 months ago

No worries. This looks good to me. @sachinmesh @anabarcelona want to take a look? https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/drafts/Keith/real-world-evidence-copy

This is the block library variations we have https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/block-library/blocks/stat-with-illustration

keith-kaplan commented 7 months ago

@nimithshetty17 I just saw the Figma file. I think we need to make the number stat a gradient like the content intro stat block.

sachinmesh commented 6 months ago

The width of the stat component is wrong, it should be desktop is 360px, tablet 275px, mobile 270px @nimithshetty17

image

CC: @keith-kaplan @anabarcelona

aem-code-sync[bot] commented 6 months ago
Page Scores Audits Google
/drafts/Keith/real-world-evidence-copy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
nimithshetty17 commented 6 months ago

@sachinmesh please check now. cc: @keith-kaplan