hlxsites / merative2

Merative.com site on Franklin
https://merative.com
Apache License 2.0
2 stars 9 forks source link

Issue 914 #376

Closed chandans1316 closed 2 months ago

chandans1316 commented 2 months ago

Issue

Fixes https://merative.atlassian.net/browse/MERATIVE-954 Fix : https://merative.atlassian.net/browse/MERATIVE-955

Description

https://merative.atlassian.net/browse/MERATIVE-955

When a content author adds the references block to a blog post, the Unordered lists/numbered lists and list items are not sized correctly. When the references block is removed, this issue gets fixed.

https://merative.atlassian.net/browse/MERATIVE-954

Tertriary button in leadspaces should be center aligned in the leadspace block. Currenlty it is aligned bottom.

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Fixes https://merative.atlassian.net/browse/MERATIVE-954

Fix : https://merative.atlassian.net/browse/MERATIVE-955

Testing Instruction

Open each New URL and inspect the code changes to ensure they render according to the Design Specs in Figma

Note: The changes are generic and affects all the support pages where "columns" and "leadspace" blocks are used.

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [67905ee](https://github.com/hlxsites/merative2/commit/67905ee17773e4968de0a760d75df7c6f67d7bd9) :arrows_counterclockwise: (latest) * [1fbca07](https://github.com/hlxsites/merative2/commit/1fbca07b0116a4672c925ee024f68204a87a44f2) :white_check_mark: * [4fbef11](https://github.com/hlxsites/merative2/commit/4fbef11d079beb51ba7341021e56f1fdbc17ffea) :white_check_mark: * [a76c679](https://github.com/hlxsites/merative2/commit/a76c67935338fef06f2ea40573ad98459aaf6966) :white_check_mark: * [ba53725](https://github.com/hlxsites/merative2/commit/ba53725b9a5c5dd8bd07aac653d2ef4529fe2fc3) :white_check_mark: * [201b311](https://github.com/hlxsites/merative2/commit/201b31148afe3b14d0afcaad9cb0da7a2be76b08) :white_check_mark: * [835eaec](https://github.com/hlxsites/merative2/commit/835eaec0502b3e10d6e862f48ee51c0eb3dcaec0) :white_check_mark: * [bf73063](https://github.com/hlxsites/merative2/commit/bf730636a5e6ea7e68d9d68842b573b433c49722) :white_check_mark: * [b28bf06](https://github.com/hlxsites/merative2/commit/b28bf06ba21dc041c38e910e02e241dd8c17fd41) :white_check_mark: * [c413b01](https://github.com/hlxsites/merative2/commit/c413b011a8d2ad3e556049b9d55dcfab0a199618) :white_check_mark: * [60e4ddf](https://github.com/hlxsites/merative2/commit/60e4ddf2cea4cd8398d55d1ac9b30026af227853) :white_check_mark: * [5a424fe](https://github.com/hlxsites/merative2/commit/5a424fec9e7bb50ea55699576084157b2c6d94de) :white_check_mark: * [578cb99](https://github.com/hlxsites/merative2/commit/578cb996c8581466a11539b088db8c9aedab7b74) :white_check_mark: * [a4ae20d](https://github.com/hlxsites/merative2/commit/a4ae20d83b868c550f32d08bd9b9909639a540a0) :white_check_mark: * [8c0f75e](https://github.com/hlxsites/merative2/commit/8c0f75e1cd6904f4145f336ffd1143095b41b0da) :white_check_mark: * [2db3c64](https://github.com/hlxsites/merative2/commit/2db3c64404ece9e3eca730330d177abf87f8ec30) :white_check_mark: * [f0762d6](https://github.com/hlxsites/merative2/commit/f0762d6dd8c466c3564c60c554b26fd4fa3c93d6) :white_check_mark: * [0ac797f](https://github.com/hlxsites/merative2/commit/0ac797f0d371cbec962f98f641b2753c20344b0d) :white_check_mark: * [dcb9482](https://github.com/hlxsites/merative2/commit/dcb9482d02709845c7800d5d3f6bda51434e02d9) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/block-library/templates/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/clinical-decision-support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
keith-kaplan commented 2 months ago

@raj-bluetext @chandans1316 @joehanchoi please reference the figma design for footnotes here for the correct styling - Figma Link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=10089%3A44814&mode=dev&t=lwqWwvMQKCZdofLG-1

keith-kaplan commented 2 months ago

@raj-bluetext @chandans1316 @joehanchoi checking on this work. Here's the links to Figma. Can you please work on bulleted list fix?

https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=10089-44822&mode=design&t=qStX3jR9aAwB4mEL-4

Typography style - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=20681-15623&mode=design&t=qStX3jR9aAwB4mEL-4