hlxsites / moleculardevices

Franklin Site for https://www.moleculardevices.com/
Apache License 2.0
5 stars 5 forks source link

UI issues on product pages #937

Closed MeghnaTewari closed 1 year ago

MeghnaTewari commented 1 year ago
  1. Please reduce the size of these images. Also in the URL it should be ".com" instead of the hyphen https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution-com

image

  1. Remove the line separator above "Assure data integrity.." https://franklin.moleculardevices.com/products/microplate-readers/absorbance-readers/spectramax-abs-plate-readers https://franklin.moleculardevices.com/products/microplate-readers/acquisition-and-analysis-software/softmax-pro-software https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software-installation-validation-services

  2. Add a little space here https://franklin.moleculardevices.com/products/microplate-readers/multi-mode-readers/filtermax-f3-f5-readers

image

  1. Centre align "Cellular Image Gallery" text. Add space above the disclaimer text and remove the letter "S" and remove the extra asterisks. https://franklin.moleculardevices.com/products/cellular-imaging-systems/high-content-imaging/imagexpress-confocal-ht-ai https://franklin.moleculardevices.com/products/cellular-imaging-systems/high-content-imaging/imagexpress-micro-confocal

image

  1. Fix the font size for this section- Center align "Turnkey solutions for ..." with font h2:36 px.
    "MetaXpress Application Modules" h2: 24px blue color "Expedite image analysis and data...." h4:18px
    https://franklin.moleculardevices.com/products/cellular-imaging-systems/acquisition-and-analysis-software/metaxpress

image

  1. View Interactive Demo CTA is not working, and remove the cross button below. Add line separators here https://franklin.moleculardevices.com/products/cellular-imaging-systems/acquisition-and-analysis-software/cellreporterxpress

image

  1. Add line separator https://franklin.moleculardevices.com/products/clone-screening/single-cell-isolation/dispencell-single-cell-dispenser

image

  1. Remove Request pricing CTA from the banner https://franklin.moleculardevices.com/products/flipr-penta-high-throughput-cellular-screening-system

  2. Empty resources https://franklin.moleculardevices.com/service-support/lab-automation-solutions/lab-automation-for-high-content-screening#resources

  3. Remove line separator https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software-installation-validation-services

image

duynguyen commented 1 year ago

@MeghnaTewari @lydiapuric FYI - I moved point 11 to a new issue #943 as it would be easier with an embedded HTML.

MeghnaTewari commented 1 year ago

Ok, thanks.

lydiapuric commented 1 year ago

@MeghnaTewari When a user requests URL https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution.com, this user is redirected internally to https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution-com. A user will never see a 404.

lydiapuric commented 1 year ago

Fixes done:

  1. Please reduce the size of these images https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution.com

  2. Remove the line separator above "Assure data integrity.." https://franklin.moleculardevices.com/products/microplate-readers/absorbance-readers/spectramax-abs-plate-readers https://franklin.moleculardevices.com/products/microplate-readers/acquisition-and-analysis-software/softmax-pro-software https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software-installation-validation-services

  3. Add a little space here https://937-products--moleculardevices--hlxsites.hlx.page/products/microplate-readers/multi-mode-readers/filtermax-f3-f5-readers

  4. Centre align "Cellular Image Gallery" text. Add space above the disclaimer text and remove the letter "S" and remove the extra asterisks. https://937-products--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/high-content-imaging/imagexpress-confocal-ht-ai https://937-products--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/high-content-imaging/imagexpress-micro-confocal

  5. Fix the font size for this section- Center align "Turnkey solutions for ..." with font h2:36 px. "MetaXpress Application Modules" h2: 24px blue color "Expedite image analysis and data...." h4:18px https://937-products--moleculardevices--hlxsites.hlx.page/products/cellular-imaging-systems/acquisition-and-analysis-software/metaxpress

  6. View Interactive Demo CTA is not working, and remove the cross button below. Add line separators here https://franklin.moleculardevices.com/products/cellular-imaging-systems/acquisition-and-analysis-software/cellreporterxpress

  7. Add line separator https://franklin.moleculardevices.com/products/clone-screening/single-cell-isolation/dispencell-single-cell-dispenser

  8. @MeghnaTewari Please clarify: Remove Request pricing CTA from the banner The Request Pricing is on the original page on the banner too. https://franklin.moleculardevices.com/products/flipr-penta-high-throughput-cellular-screening-system

  9. Empty resources https://franklin.moleculardevices.com/service-support/lab-automation-solutions/lab-automation-for-high-content-screening#resources

  10. Remove line separator https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software https://franklin.moleculardevices.com/products/gxp-compliance-solutions/softmax-pro-gxp-software-installation-validation-services

Additional reported styling issues for Category pages (blue title, title center align, font html snippet, buttons in same row) https://937-products--moleculardevices--hlxsites.hlx.page/products/gxp-compliance-solutions

MeghnaTewari commented 1 year ago

@lydiapuric Can you pls provide the URL where I can verify the fixes?

mhaack commented 1 year ago

@MeghnaTewari When a user requests URL https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution.com, this user is redirected internally to https://franklin.moleculardevices.com/products/3d-biology/3d-bioprinting-bab400-bioprinter-automation-solution-com. A user will never see a 404.

To add on this a . is not supported in Franklin as part of the document name.

lydiapuric commented 1 year ago

@MeghnaTewari If you see franklin.moleculardevices.com still in the validation link, it was only a content change necessary to fix the issue, no code changes.

MeghnaTewari commented 1 year ago

@lydiapuric All the issues are still reproducible to me. Sharing screenshots for some-

The line separator is still there -

https://franklin.moleculardevices.com/products/microplate-readers/absorbance-readers/spectramax-abs-plate-readers image

Space is not added

https://franklin.moleculardevices.com/products/microplate-readers/multi-mode-readers/filtermax-f3-f5-readers image

Text is not center aligned https://franklin.moleculardevices.com/products/cellular-imaging-systems/high-content-imaging/imagexpress-confocal-ht-ai image

MeghnaTewari commented 1 year ago

Some more minor UI issues I have identified-

https://franklin.moleculardevices.com/products/gxp-compliance-solutions

  1. Centre align all the h2 titles
  2. Font looks different here

image

Live- image

  1. Update font size to be 40px with blue color image

  2. Reduce font size to 24px

image

  1. Align button parallelly

image

lydiapuric commented 1 year ago

@MeghnaTewari Til now I was able to work on points 1 - 3, see progress, comments and URLs in https://github.com/hlxsites/moleculardevices/issues/937#issuecomment-1647675704 The other issues are not yet addressed!

MeghnaTewari commented 1 year ago

These changes look good.

lydiapuric commented 1 year ago

@MeghnaTewari All issues incl. new ones got addressed, please validate. See validation issues and URLs in https://github.com/hlxsites/moleculardevices/issues/937#issuecomment-1647675704

MeghnaTewari commented 1 year ago
  1. @MeghnaTewari Please clarify: Remove Request pricing CTA from the banner The Request Pricing is on the original page on the banner too. https://franklin.moleculardevices.com/products/flipr-penta-high-throughput-cellular-screening-system

The request pricing CTA should only be visible for US and EU regions. Currently, it is visible for all the regions.

For US and EU there should be these 2 CTA buttons image

For all the other regions it should be this-

image

cc @mhaack

MeghnaTewari commented 1 year ago

@MeghnaTewari All issues incl. new ones got addressed, please validate. See validation issues and URLs in #937 (comment)

Verified, looks good.

mhaack commented 1 year ago

@lydiapuric @MeghnaTewari on the request pricing C2A, yes this should work this was implemented by @andreituicu.

lydiapuric commented 1 year ago

@mhaack I rechecked, and this is what I see: When I am in with CH, IE (EU) or US, I see 3 buttons. (Tested with VPN, cleaning up local storage for 'ipstack:geolocation' and making sure I see the changed country code / continent code with JSON.parse(localStorage.getItem('ipstack:geolocation')).continent_code)

Screenshot 2023-07-26 at 11 34 46

I will create a separate issue to work on this.

mhaack commented 1 year ago

Thanks yes I think we currently only cover hiding & un-hidding of the request pricing button. But not hiding & un-hidding of an alternative button. @MeghnaTewari are we ok, for interim, to have 3 buttons in eu/us? While outside of these the request pricing is not shown aka. only two buttons?

MeghnaTewari commented 1 year ago

@mhaack The Franklin site should follow the same as the live site as it is intentional to hide the 'download brochure' alternative CTA for US and EU regions. As for whether we should keep all three buttons for US and EU, I don't think I can make that decision.

lydiapuric commented 1 year ago

@MeghnaTewari Could you please verify the CTA buttons? https://franklin.moleculardevices.com/products/flipr-penta-high-throughput-cellular-screening-system

MeghnaTewari commented 1 year ago

@lydiapuric Looking fine for other regions. But for US and EU I am still seeing the 'download brochure' CTA.

image

MeghnaTewari commented 1 year ago

Also, the Request Pricing CTA should be orange and white on the hover. The second CTA should be white outlined with the same hover behavior ( This used to be correct on Franklin earlier )

Example from live - image

Both the CTAs are blue on Franklin-

image

lydiapuric commented 1 year ago

@MeghnaTewari Thanks for the quick validation. I will address the mentioned issues.

lydiapuric commented 1 year ago

@MeghnaTewari Regarding CTA buttons and Pricing, can you please retest in https://937-pricing--moleculardevices--hlxsites.hlx.page/products/flipr-penta-high-throughput-cellular-screening-system

MeghnaTewari commented 1 year ago

@lydiapuric Everything else looks fine, just one more thing that for the regions except the US and EU the color of the primary button should be blue.

image

image

lydiapuric commented 1 year ago

@MeghnaTewari Thanks, so the pricing button is orange, but the non-EU primary button is blue. I missed that one, adjusting...

MeghnaTewari commented 1 year ago

Correct.

lydiapuric commented 1 year ago

@MeghnaTewari Changes done, please retest. https://937-pricing--moleculardevices--hlxsites.hlx.page/products/flipr-penta-high-throughput-cellular-screening-system

MeghnaTewari commented 1 year ago

Looks great! Thanks.