hlxsites / petplace

PetPlace.com AEM Edge Delivery Services site for 24PetHealth
https://www.petplace.com
Apache License 2.0
4 stars 10 forks source link

fix: Content and Design QA #197

Closed ramboz closed 1 year ago

ramboz commented 1 year ago

Ideally, we should all verify a random subset of pages to make sure they look good. I'm preparing a few sets of 20 pages below for each of us to verify.

The goal is to identify remaining bugs:

It is enough to document those, and we'll prioritize the fixing separately.

Summary:

ramboz commented 1 year ago
ramboz commented 1 year ago
ramboz commented 1 year ago
ramboz commented 1 year ago
ramboz commented 1 year ago
FentPams commented 1 year ago

After reviewing the pages above, there are several issues found (pls ignore it if these changes are done intentionally): The pages with checks ✔️have typical types of issues, but many other pages have the same issues.

  1. Lack of Article page navigation at the bottom (below is example):
Petplace (first pic) Hlx.live (second pic)
https://www.petplace.com/article/birds/general/what-to-do-if-your-bird-flies-the-coop/ https://main--petplace--hlxsites.hlx.live/article/birds/general/what-to-do-if-your-bird-flies-the-coop
Screenshot 2023-06-29 at 10 19 21 PM Screenshot 2023-06-29 at 10 19 15 PM
FentPams commented 1 year ago
  1. Article page navigation miss " > next article" -- The article navigation doesn't show "previous-thumbnail, and previous detail <1024px "(display:none). Some pages can work as expected, but most can't. Same for the screen >1024, the "next-thumbnail, next-details, next", don't show either.
Petplace (1st. 2nd pic) Hlx.live (3rd, 4th pic)
https://www.petplace.com/article/dogs/breeds/dog-breeds/meet-the-vizsla/ https://main--petplace--hlxsites.hlx.live/article/dogs/breeds/dog-breeds/meet-the-vizsla
FentPams commented 1 year ago

3. h2 .subtitle doesn't style correctly.

In their page, many h2 has .subtitle class, with font 1.25rem. while we style it merely as h2.

Petplace(left) Hlx.live(right)
https://www.petplace.com/article/cats/diseases-conditions-of-cats/fishhook-injuries-in-cats/ https://main--petplace--hlxsites.hlx.live/article/cats/diseases-conditions-of-cats/fishhook-injuries-in-cats/
Screenshot 2023-06-29 at 10 43 02 PM
FentPams commented 1 year ago

4. Markup text issue in doc.

For the html structure like this:

<h2>
     <p> </p>  
     <p> </p>  
          …
</h2> 
Screenshot 2023-06-29 at 10 53 49 PM Screenshot 2023-06-29 at 11 03 55 PM
FentPams commented 1 year ago

5. Blank page

https://main--petplace--hlxsites.hlx.live/article/reptiles/general/turtle-sales-pose-risks-to-human-health-and-animal-welfare

FentPams commented 1 year ago

6. "Undefined breadcrumb" in authors page

Petplace Hlx.live
https://www.petplace.com/authors/carey-hemmelgarn-dvm-dacvecc/ https://main--petplace--hlxsites.hlx.page/authors/carey-hemmelgarn-dvm-dacvecc
Screenshot 2023-06-29 at 11 28 11 PM
FentPams commented 1 year ago

7. Special layouts issue

Petplace Hlx.live
https://www.petplace.com/give-the-gift-of-pet-insurance/ https://main--petplace--hlxsites.hlx.live/give-the-gift-of-pet-insurance
Screenshot 2023-06-29 at 11 30 24 PM
FentPams commented 1 year ago

8. Theme color mismatch

Petplace Hlx.live
https://www.petplace.com/article/category/breeds/cat-breeds/ https://main--petplace--hlxsites.hlx.live/article/cats/breeds/cat-breeds/what-you-need-to-know-about-legal-exotic-cats
Screenshot 2023-06-29 at 11 32 31 PM
FentPams commented 1 year ago

9. Text color issue

Petplace Hlx.live
https://www.petplace.com/article/dogs/vet-qa-parent/vet-qa/what-is-the-history-of-the-pug/ https://main--petplace--hlxsites.hlx.live/article/dogs/vet-qa-parent/vet-qa/what-is-the-history-of-the-pug
Screenshot 2023-06-29 at 11 59 16 PM
FentPams commented 1 year ago

10.h3 style in popular posts and in text

Screenshot 2023-06-29 at 11 56 48 PM
FentPams commented 1 year ago

11. Margin issue

Screenshot 2023-06-29 at 11 57 39 PM
FentPams commented 1 year ago

12. Other text style issue:

Petplace Hlx.live
https://www.petplace.com/article/cats/vet-qa-parent/vet-qa/why-does-my-cat-sleep-so-much/ https://main--petplace--hlxsites.hlx.live/article/cats/vet-qa-parent/vet-qa/why-does-my-cat-sleep-so-much
Screenshot 2023-06-30 at 12 00 57 AM
FentPams commented 1 year ago

13. Extra symbols**

Petplace Hlx.live
https://www.petplace.com/article/dogs/vet-qa-parent/vet-qa/what-is-gastric-lavage/ https://main--petplace--hlxsites.hlx.live/article/dogs/vet-qa-parent/vet-qa/what-is-gastric-lavage
Screenshot 2023-06-30 at 12 02 09 AM
FentPams commented 1 year ago

14. Content order issue

Petplace Hlx.live
https://www.petplace.com/article/general/news/new-york-banning-retail-pet-sales-puppy-mills/ https://main--petplace--hlxsites.hlx.live/article/general/news/new-york-banning-retail-pet-sales-puppy-mills
Screenshot 2023-06-30 at 12 03 10 AM
FentPams commented 1 year ago

15 Link or Button ?

Petplace Hlx.live
https://www.petplace.com/article/dogs/vet-qa-parent/vet-qa/what-pets-do-the-2008-presidential-candidates-have/ https://main--petplace--hlxsites.hlx.live/article/dogs/vet-qa-parent/vet-qa/what-pets-do-the-2008-presidential-candidates-have
Screenshot 2023-06-30 at 12 03 57 AM

my note 👈 , feel free to refer it if needed :)

travrob1 commented 1 year ago

Disclosure coming after table of contents Theirs:

Image

Ours:

Image

Source: https://main--petplace--hlxsites.hlx.live/article/dogs/pet-health/dog-health/dog-diet-nutrition/can-dogs-eat-blueberries#h2

FentPams commented 1 year ago

16 The Email us link broken and not redirects to our 404 page or the main page.

https://main--petplace--hlxsites.hlx.live/article/dogs/pet-care/great-name-ideas-for-sporting-dogs

Screenshot 2023-06-30 at 12 53 31 PM Screenshot 2023-06-30 at 12 53 38 PM
ramboz commented 1 year ago

Since, it's a bit hard to directly comment on each, I'll use the following emoji notation to triage/track each item:

ramboz commented 1 year ago

For https://github.com/hlxsites/petplace/issues/197#issuecomment-1614811976, waiting on Matt to review the special pages and see what he wants to do with those. Likely post-golive

ramboz commented 1 year ago

For https://github.com/hlxsites/petplace/issues/197#issuecomment-1615134417, the link is also broken on their page, so we won't do anything about it. I'm reporting all the broken links separately and Matt and I will discuss how to address those in a different thread