Closed ramboz closed 1 year ago
After reviewing the pages above, there are several issues found (pls ignore it if these changes are done intentionally): The pages with checks ✔️have typical types of issues, but many other pages have the same issues.
Petplace (1st. 2nd pic) | Hlx.live (3rd, 4th pic) |
---|---|
https://www.petplace.com/article/dogs/breeds/dog-breeds/meet-the-vizsla/ | https://main--petplace--hlxsites.hlx.live/article/dogs/breeds/dog-breeds/meet-the-vizsla |
>1024 petplace
<1024 petplace
>1024 hlx
<1024 hlx
In their page, many h2 has .subtitle class, with font 1.25rem. while we style it merely as h2.
For the html structure like this:
<h2>
<p> </p>
<p> </p>
…
</h2>
https://main--petplace--hlxsites.hlx.live/article/cats/pet-health/cleft-palate-in-cats (I have manually adjusted its doc, but I guess there may be more pages like this)
https://main--petplace--hlxsites.hlx.live/article/dogs/pet-health/malassezia-dermatitis-in-dogs (this one without fix yet)
Petplace | Hlx.live |
---|---|
https://www.petplace.com/authors/carey-hemmelgarn-dvm-dacvecc/ | https://main--petplace--hlxsites.hlx.page/authors/carey-hemmelgarn-dvm-dacvecc |
Petplace | Hlx.live |
---|---|
https://www.petplace.com/give-the-gift-of-pet-insurance/ | https://main--petplace--hlxsites.hlx.live/give-the-gift-of-pet-insurance |
Disclosure coming after table of contents Theirs:
Ours:
https://main--petplace--hlxsites.hlx.live/article/dogs/pet-care/great-name-ideas-for-sporting-dogs
Since, it's a bit hard to directly comment on each, I'll use the following emoji notation to triage/track each item:
For https://github.com/hlxsites/petplace/issues/197#issuecomment-1614811976, waiting on Matt to review the special pages and see what he wants to do with those. Likely post-golive
For https://github.com/hlxsites/petplace/issues/197#issuecomment-1615134417, the link is also broken on their page, so we won't do anything about it. I'm reporting all the broken links separately and Matt and I will discuss how to address those in a different thread
Ideally, we should all verify a random subset of pages to make sure they look good. I'm preparing a few sets of 20 pages below for each of us to verify.
The goal is to identify remaining bugs:
It is enough to document those, and we'll prioritize the fixing separately.
Summary: