hlxsites / prisma-cloud-docs-website

blocks and gdoc authored content for https://docs.prismacloud.io
Apache License 2.0
3 stars 3 forks source link

[AsciiDoc conversion] Inline cross references in table cells wrapped in para tags #201

Closed iansk closed 1 year ago

iansk commented 1 year ago

Inline cross references (with the AsciiDoc xref: macro) are being wrapped in an extra <p> tag when the cross reference is in a table cell.

For example, this AsciiDoc source specifies that everything, including the cross-ref, should be in a single para:

A comprehensive view of an organization's engineering technical stack from repository to deployment. See xref:visibility/repositories.adoc[here] for more on Repositories.

But the link in the table is put into it's own para. Screenshot of this issue (the first red box corresponds to the AsciiDoc code snippet above):

franklin-uat-xrefs-in-tables

Link to the page:

https://main--prisma-cloud-docs-website--hlxsites.hlx.live/en/enterprise-edition/content-collections/application-security/familiarize-application-security#fundamental-concepts

When inspecting the link element, I see it's wrapped in an extra <p> tag:

franklin-uat-xrefs-in-tables2

Expected result:

There should be no extra <p> tag around cross references, unless explicitly specified in the underlying AsciiDoc source. In the screenshot, all the text in column 2 of both rows should be in a single para, not spread across three paras.

maxakuru commented 1 year ago

fixed in https://github.com/hlxsites/prisma-cloud-docs/pull/121 & https://github.com/hlxsites/prisma-cloud-docs/pull/122 will need to republish docs to get those changes