Revert "lighthouse improvements for article pages"

iansk commented 4 months ago

Reverts hlxsites/prisma-cloud-docs-website#231

aem-code-sync[bot] commented 4 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [bf08711](https://github.com/hlxsites/prisma-cloud-docs-website/commit/bf0871195b5974144977666fcfce75e465f08be8) :white_check_mark: (latest)

iansk commented 4 months ago

@maxakuru I'm going to revert this PR for now because it breaks a couple of things:

When you paste a link with a fragment into the browser's address bar, the page no longer auto-scrolls to the right heading. This is due to the new placement of this code block.
The "On this page" outline on the right side of the page no longer captures all headings. This is due to the new makeHeadersSequential() function.

I think there's good stuff in this PR, but I need some more time to review it. I also need to get the link fragment thing working ASAP because when we share links with fragments with customers, we want them to get to the relevant section out of the gate.

hlxsites / prisma-cloud-docs-website

Revert "lighthouse improvements for article pages" #239