hlxsites / servicenow

Apache License 2.0
2 stars 3 forks source link

Tracking of video and social share #109

Closed sergiucoman closed 11 months ago

sergiucoman commented 11 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #60

Test URLs:

aem-code-sync[bot] commented 11 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sergiucoman commented 11 months ago

This is currently blocked by https://github.com/hlxsites/servicenow/pull/106

andreituicu commented 11 months ago

Sorry, I also meant to say: I think this is exactly the kind of code we should be transferring from their analytics tracking code to ours. 👍 The part which I'm not fully sure is (as we discussed) is how to make sure that we transferred everything and that's where we need their help. But what we can find we should already transfer.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
sergiucoman commented 11 months ago

Sorry, I also meant to say: I think this is exactly the kind of code we should be transferring from their analytics tracking code to ours. 👍 The part which I'm not fully sure is (as we discussed) is how to make sure that we transferred everything and that's where we need their help. But what we can find we should already transfer.

True, this is based solely on our reverse engineering the existing code. There might be other analytics code that needs to be integrated.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blogs/2023/demo/3-ways-enhance-digital-experiences PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blogs/2023/demo/3-ways-enhance-digital-experiences PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI