hlxsites / servicenow

Apache License 2.0
2 stars 3 forks source link

fixed safari, card width issue. #113

Closed bala-servicenow closed 11 months ago

bala-servicenow commented 11 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #48

Test URLs:

in safari

aem-code-sync[bot] commented 11 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blogs/category/company-news PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
andreituicu commented 11 months ago

@bala-servicenow this fix is breaking the sidebar cards and the ones from the homepage.

please check also on safari:

Since the blog list is inheriting the CSS from the cards, but has another file where there are more specific CSS rules, maybe you can apply a width fix in: https://github.com/hlxsites/servicenow/blob/main/blocks/blog-list/blog-list.css

aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/blogs/category/company-news PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI