25 - 404 Handler: Improvement

hlxsites / servicenow

Apache License 2.0

2 stars 3 forks source link

25 - 404 Handler: Improvement #245

Closed andreituicu closed 4 months ago

andreituicu commented 4 months ago

Fix #25

The Content Security Policy from servicenow.com doesn't allow adding iframes for the .live and .page domains, but that doesn't prevent us from creating the iframe in production.

This PR when merged will introduce a canary logic so we can test in production if iframeing the 404 page would work, thus allowing us not to change the window location.

aem-code-sync[bot] commented 4 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [dc06547](https://github.com/hlxsites/servicenow/commit/dc06547c5a686b87ee841d7568378690370eba9c) :white_check_mark: (latest)