hlxsites / sunstar-foundation

Apache License 2.0
0 stars 2 forks source link

Add changes for researchreport pages #111

Closed RitwikSrivastava closed 9 months ago

RitwikSrivastava commented 10 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #

Test URLs:

Block Name Documentation
For e.g. cards doc-link
Variation Name Documentation
For e.g. cards (grid) doc-link
aem-code-sync[bot] commented 10 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [8b548a8](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/8b548a8b570029b083d44228ffa87e7644b5b19e) :white_check_mark: (latest) * [483adaf](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/483adaf41639940546bab466253e6c9a318f913c) :white_check_mark: * [ff6dabd](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/ff6dabd2eb6c54262a8f73b4d12107afcd79be86) :white_check_mark: * [490b905](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/490b905fac8d3779d2316bee2f9183bb5b7da297) :white_check_mark: * [bba05de](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/bba05deb85a042757bdc4100d6f909cd944c8011) :white_check_mark: * [2f38f37](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/2f38f37444c0bf34c68641bfc8b51b845f172dbc) :white_check_mark: * [afc6e11](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/afc6e110770e4dbcc5624df21c7b07f02e47d504) :white_check_mark: * [0794549](https://github.com/hlxsites/sunstar-foundation/pull/111/commits/0794549576f823bd50828c1412996abec5e5a165) :white_check_mark:
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/grants/research-report PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
bosschaert commented 10 months ago

The table still looks quite different on the test URL page:

Original:

Screenshot 2024-01-17 at 10 42 53

This branch:

Screenshot 2024-01-17 at 10 42 58
JiangLong2019 commented 10 months ago

In mobile view, there are some details things like padding and space that need to be checked.

Original site:

image

EDS site:

image
RitwikSrivastava commented 9 months ago

@bosschaert Can you please re-review ?

bosschaert commented 9 months ago

@RitwikSrivastava could you please confirm that the reported visual changes are no issue?

github-actions[bot] commented 9 months ago

:small_orange_diamond: 9 visual differences detected

The diff images are attached in the artifact

RitwikSrivastava commented 9 months ago

@bosschaert As all the style changes are for orderedtext variant, I can confirm that the reported visual changes are not an issue. I have checked those also.