search

hlxsites / sunstar-foundation

Apache License 2.0
0 stars 2 forks source link

Breadcrumb Changes wrt to redirect pages #163

Closed jindaliiita closed 9 months ago

jindaliiita commented 9 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes

Test URLs:

Block Name Documentation
For e.g. cards doc-link
Variation Name Documentation
For e.g. cards (grid) doc-link
aem-code-sync[bot] commented 9 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [9b8d981](https://github.com/hlxsites/sunstar-foundation/pull/163/commits/9b8d98148647133b43b1f5d3605041e2d6a7f7d3) :white_check_mark: (latest)
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/archives/dentistry/news/20220920 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
jindaliiita commented 9 months ago

I am not sure if this is the right way to handle below type of cases.

For path /archives/dentistry/news/20220920, breadcrumb is not coming properly because prefix path /archives/dentistry/news is being redirected to /dentistry/news. So, its entry is not present in query-index.json. Redirection mapping is only present in redirects.json. That's why i have to fetch redirects.json through breadcrumb block.

JiangLong2019 commented 9 months ago

A simple idea is that remove /archives directory from sharepoint to keep all in the same directory level, and add redirection /archives/dentistry/news/ → /dentistry/news/ What do you think?

jindaliiita commented 9 months ago

A simple idea is that remove /archives directory from sharepoint to keep all in the same directory level, and add redirection /archives/dentistry/news/ → /dentistry/news/ What do you think?

Yes, apart from this, I also don't see any other alternative. This issue is also present on experience pages. @sdmcraft @bosschaert @ehrro Your thoughts on this ?

bosschaert commented 9 months ago

Yes, apart from this, I also don't see any other alternative. This issue is also present on experience pages. @sdmcraft @bosschaert @ehrro Your thoughts on this ?

Sounds reasonable to me. The URL of the dentistry news articles is changing anyway because of the Japanese characters in the URL which has now become a date, so we could maybe just put them in /dentistry/news in the first place.

jindaliiita commented 9 months ago

Yes, apart from this, I also don't see any other alternative. This issue is also present on experience pages. @sdmcraft @bosschaert @ehrro Your thoughts on this ?

Sounds reasonable to me. The URL of the dentistry news articles is changing anyway because of the Japanese characters in the URL which has now become a date, so we could maybe just put them in /dentistry/news in the first place.

True but there are other cases also like experience pages

jindaliiita commented 9 months ago

@ehrro Can you please confirm Whether we can move /archives/dentistry/news/ pages to /dentistry/news/ And /experience/ pages to /grants/experience/

ehrro commented 9 months ago

Hello @jindaliiita yes I confirm you can move it from archive. Thank you.

jindaliiita commented 9 months ago

Closing this PR as changes are not needed