Absolutely position only the play button and not the placeholder image

hlxsites / sunstar-foundation

Apache License 2.0

0 stars 2 forks source link

Absolutely position only the play button and not the placeholder image #174

Closed sdmcraft closed 9 months ago

sdmcraft commented 9 months ago

Test URLs:

Original: https://www.sunstar-foundation.org/for-healthcare-info/education
Before: https://main--sunstar-foundation--hlxsites.hlx.live/for-healthcare-info/education
After: https://embed-placehoder--sunstar-foundation--hlxsites.hlx.live/for-healthcare-info/education
[ ] New Blocks introduced in this PR If yes, please provide details below

Block Name	Documentation
For e.g. cards	doc-link

[ ] New variations introduced in this PR

Variation Name	Documentation
For e.g. cards (grid)	doc-link

aem-code-sync[bot] commented 9 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [2a0483e](https://github.com/hlxsites/sunstar-foundation/pull/174/commits/2a0483effd04ecaa89cb5aa7e01c5b83c6d30535) :white_check_mark: (latest)

aem-code-sync[bot] commented 9 months ago

Page	Scores	Audits	Google
/for-healthcare-info/education

sdmcraft commented 9 months ago

@bosschaert , @jindaliiita , the only page I know where we are using an embed block with placeholder is the one I added in PR description. And this PR fixes a styling issue on this page. But if you are aware of any page which uses embed block with placeholder, please let me know and I'd confirm if this change doesn't cause any issue there. I used the finder tool and didn't find any page other than this one.