hlxsites / sunstar-foundation

Apache License 2.0
0 stars 2 forks source link

new carousel variant with text overlapping the background image and with no swiper control . #182

Closed RitwikSrivastava closed 7 months ago

RitwikSrivastava commented 7 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #

Test URLs:

Block Name Documentation
For e.g. cards doc-link
Variation Name Documentation
For e.g. cards (grid) doc-link
aem-code-sync[bot] commented 7 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [c05b46d](https://github.com/hlxsites/sunstar-foundation/pull/182/commits/c05b46d7ac0a57762c1c90d662fb8351010192bf) :white_check_mark: (latest) * [e0c2439](https://github.com/hlxsites/sunstar-foundation/pull/182/commits/e0c243930b7859a51304c2b30dace68a59796800) :white_check_mark: * [b0e1c23](https://github.com/hlxsites/sunstar-foundation/pull/182/commits/b0e1c23e99a3bb0850e22b50b9a1da89547b5deb) :white_check_mark: * [226707b](https://github.com/hlxsites/sunstar-foundation/pull/182/commits/226707b3f1b1aebf6872064ef3cc3c5254d1e221) :white_check_mark: * [e71e137](https://github.com/hlxsites/sunstar-foundation/pull/182/commits/e71e137a0997320bd8402a931633a8e1bfd523ad) :white_check_mark: * [6c4d3d9](https://github.com/hlxsites/sunstar-foundation/pull/182/commits/6c4d3d989148ab1c4b6facf84e854779383c433d) :white_check_mark:
aem-code-sync[bot] commented 7 months ago
Page Scores Audits Google
/_drafts/ritwik/test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
JiangLong2019 commented 7 months ago

Some comments:

  1. The image shows different in mobile view

Original site:

image

EDS:

image
  1. Missing padding around description Original site: image

EDS:

image
  1. Nit: the space under description shows big in mobile view image
bosschaert commented 7 months ago

I do see a blue banner at the bottom which the original site doesn't have:

Helix:

Screenshot 2024-02-06 at 11 15 04

Original:

Screenshot 2024-02-06 at 11 15 12
RitwikSrivastava commented 7 months ago

I do see a blue banner at the bottom which the original site doesn't have:

Fixed. Please check. @bosschaert

github-actions[bot] commented 7 months ago

:small_orange_diamond: 2 visual differences detected

The diff images are attached in the artifact