hlxsites / sunstar-foundation

Apache License 2.0
0 stars 2 forks source link

Issue202 dentistry faq page - https://www.sunstar-foundation.org/dentistry/faq #203

Closed meejain closed 8 months ago

meejain commented 9 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #202

Test URLs:

Block Name Documentation
For e.g. cards doc-link
Variation Name Documentation
For e.g. cards (grid) doc-link
aem-code-sync[bot] commented 9 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [b9aa951](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/b9aa9519bb65438dfc25b64b38ce37752f0ee949) :white_check_mark: (latest) * [dcea162](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/dcea162af9d75eb8b27c07cca31be9df263b1267) :white_check_mark: * [a82746b](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/a82746bed2af885377559832c60c4eaf4a3138f7) :white_check_mark: * [8bcf816](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/8bcf816ff490ee6a22a3bd3bb063b80a3e49c45c) :white_check_mark: * [3e9823b](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/3e9823b8396b715f963912999aa126d68878b0b2) :white_check_mark: * [d79f27c](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/d79f27cb0b148485e2703635b8805fba547046e0) :white_check_mark: * [7d6a1ab](https://github.com/hlxsites/sunstar-foundation/pull/203/commits/7d6a1ab0eaf4723a4735ecb4e107b028f582aba1) :white_check_mark:
aem-code-sync[bot] commented 9 months ago
Page Scores Audits Google
/dentistry/faq PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
JiangLong2019 commented 9 months ago

Some comments:

  1. Need padding in mobile view

    image
  2. Nit: maybe it looks comfortable that keep the color ground of the title the same as the original site

Original site:

image

EDS:

image
meejain commented 9 months ago

Some comments:

  1. Need padding in mobile view
image
  1. Nit: maybe it looks comfortable that keep the color ground of the title the same as the original site

Original site: image

EDS: image

Fixed now -

![Uploading image.png…]()

meejain commented 9 months ago
image
github-actions[bot] commented 9 months ago

:small_orange_diamond: 9 visual differences detected

The diff images are attached in the artifact

JiangLong2019 commented 8 months ago

Hi @meejain maybe we are looking at diffferent urls, on this page https://issue202-dentistry-faq--sunstar-foundation--hlxsites.hlx.live/dentistry/faq I still can see some titles are missing padding, such as "よくある質問", "診療について". How about your side?

image
meejain commented 8 months ago

Hi @meejain maybe we are looking at diffferent urls, on this page https://issue202-dentistry-faq--sunstar-foundation--hlxsites.hlx.live/dentistry/faq I still can see some titles are missing padding, such as "よくある質問", "診療について". How about your side?

image

Added "padded" to the section to have it all across with consistency -

image