search

hlxsites / sunstar-foundation

Apache License 2.0
0 stars 2 forks source link

Migrate Varians from sunstar.com #206

Closed ehrro closed 7 months ago

ehrro commented 7 months ago

Can you please migrate the following variants from sunstar.com:

  1. Columns block:

    • Flex start (this variant not needed if we can control it via markdown with vertical align in word)
    • Native Image Sizes
    • no padding

  2. Containers

    • Narrower
shrotia commented 7 months ago

@ehrro

Flex start

The flex-start variant of columns block already exist (code link)

no padding

did you meant no-padding section ? As I didn't find no-padding variant at Columns block in sunstar.com (code link)

Narrower I can see Narrower variant for Section already exist (code link), did you meant Narrower variant for some other block? please confirm

shrotia commented 7 months ago

Native Image Sizes

PR raised: https://github.com/hlxsites/sunstar-foundation/pull/208

ehrro commented 7 months ago

Hello @shrotia my bad.

The form-container has a specific width on sunstar.com I thought it was narrower but it's not.

Is it possible to implement the same size as on sunstar.com?

Thanks a lot.

shrotia commented 7 months ago

form-container

yes, I can introduce another variant. The width of the was increased as part of PR for this page

shrotia commented 7 months ago

@ehrro introduced Narrower variant for Forms - Library Link

Please have a look at the PR and let me know if there is any other variant/change from sunstar.com needs to be ported in sunstar-foundation?