Closed JiangLong2019 closed 6 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/healthy-thinking/tag/education |
@sdmcraft EDS doesn't support url parameters in redirect source URL, I'll try to find any other way to deal with it rather than redirects.xls
Redirect existing tag page URL to the new format.
https://discord.com/channels/1131492224371277874/1207624789083168768/1207749171969265664
Changes looks fine to me
@sdmcraft EDS doesn't support url parameters in redirect source URL, I'll try to find any other way to deal with it rather than redirects.xls
Redirect existing tag page URL to the new format.
https://discord.com/channels/1131492224371277874/1207624789083168768/1207749171969265664
If query parameter based redirects are not possible then how would we solve the original problem i.e. having the right canonical url on the page?
@sdmcraft
If query parameter based redirects are not possible then how would we solve the original problem i.e. having the right canonical url on the page?
After the change, each tag page owns correct canonical url now. The problem is that we wanted to redirect current site tag page to the new tag page, let's say, Current tag page - https://www.sunstar.com/healthy-thinking/tag?feed-tags=germany New tag page - https://www.sunstar.com/healthy-thinking/tag/germany
In redirects.xls, the source URL doesn't support URL with parameter, we cannot use redirects.xls for the redirection. In my opinion, I don't think it's necessary, maybe we can ignore it.
@sdmcraft As we discussed, I've added the redirection for URL parameter tag page. Please have a check. https://github.com/hlxsites/sunstar/pull/576/files#diff-fbceb58f32b99b8a5309251f8c49ac8eda82fba58b905c600c92bce1ed2a1c8c
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:
Issue
Fixes #575
Changelog:
Test URLs: