search

hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

[Post Go Live] Bug - Major - Carousel (Cards) block causes Mobile and Tablet view to scroll out of frame #425

Open Andrei-Boiangiu opened 11 months ago

Andrei-Boiangiu commented 11 months ago

When opening, for example, https://www.macktrucks.com/trucks/pinnacle-series/ on Mobile or Tablet - the Carousel (Cards) block causes the whole page to have scroll out of frame

Steps to reproduce:

  1. Open https://www.macktrucks.com/trucks/pinnacle-series/ on Mobile view
  2. Notice that the page can scroll out of frame
  3. Scroll down to the Carousel (Cards) block and see how it spills out of frame
  4. Repeat steps 1 - 3 on Tablet for the same result

Expected result Page should not scroll out of frame on Mobile or Tablet view

Actual result Carousel (Cards) block causes the page to scroll out of frame on Mobile or Tablet view

image

shirin27 commented 10 months ago

To check if it's fixed by the re-design @shirin27 link the ticket

BeckyMedlin commented 10 months ago

@shirin27 Please advise if this is fixed with the redesign (see previous comment). Thank you!

shirin27 commented 10 months ago

@BeckyMedlin the Pinnacle PDP is in scope for redesign, the cards have already been re-styled for Mack: https://github.com/Netcentric/vg-macktrucks-com-rd/issues/23

I suggest we close this bug, if you agree.

BeckyMedlin commented 10 months ago

I agree. Thank you, @shirin27 !