hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

FR: Image Collage Block (Landing Page) (2) #600

Closed shirin27 closed 3 weeks ago

shirin27 commented 6 months ago

From vg-macktrucks-com-rd created by Gonzalo-CG: Netcentric/vg-macktrucks-com-rd#117

Description

The Bulldog Magazine Blog page contains an image collage-like component that displays elements following a grid pattern on desktop viewports (on mobile, the structure is simply one image below the other as seen on Figma):

Acceptance Criteria

User AC

Editor AC

Non-functional AC

Out of Scope

Open Questions

Attachment / link to Figma

here in Figma

shirin27 commented 6 months ago

@WendyKruger Please see "Open Questions" above.

shirin27 commented 6 months ago

to cover Section Metadata: Horizontal Separator #130 with this when deployed

shirin27 commented 6 months ago

Per comment from Matt here: https://www.figma.com/file/oNwe2jHIICPMIe551EY62l?node-id=2222:50863&mode=design#595563726 there should be a hover effect to enlarge image. Note: he also commented that there should be arrows for the nav instead of dots. the figma file is updated.

alexiscoelho commented 2 months ago

As agreed with @ZoeBeykirch and @BeckyMedlin this component functionality and setup will be merged with the one created on #605 As part of that this work will be done:

girishdigrajkar commented 1 month ago

Hi @alexiscoelho, Validated and below is outstanding observation :

Across Viewports:

  1. sign ‘ -> ‘ is not displayed as expected Reference : https://github.com/hlxsites/vg-macktrucks-com/issues/600#issuecomment-1966646011
girishdigrajkar commented 1 month ago

Validated and above mentioned issue is also resolved hence, please proceed with PR merge and marking ticket to 'ready for prod':

image