hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

FR: V2 Embed – Video Custom controls (#4 of 4) #664

Open cogniSyb opened 5 months ago

cogniSyb commented 5 months ago

From vg-macktrucks-com created by mollyaljenkins: hlxsites/vg-macktrucks-com#650

Must be completed after https://github.com/hlxsites/vg-macktrucks-com/issues/589

Description As a content editor I want to be able to display custom controls for configuration of video.

User AC:

Editor AC:

Functionalities

Note The same solution of uploading a less than 2 min video for Volvo sites is to be reused here

Play/pause button refer to:

Audio controls refer to:

This work is also needed for Volvo Trucks videos.

Out of Scope AEM Assets does not need to be a requirement for this ticket as per @WendyKruger

Figma:

Article Page: image

BeckyMedlin commented 4 months ago

@mollyaljenkins @verareljic Please add this to the next refinement as it is also needed for Volvo Trucks. Thanks!

BeckyMedlin commented 3 months ago

@cogniSyb Per discussion with @WendyKruger would like the functionality in the regular hero as well, not just the magazine.

cogniSyb commented 3 months ago

@BeckyMedlin that’s alright. The functionality we’ll copy from Volvo Trucks will support usage in several blocks.

mollyaljenkins commented 3 months ago

In issue: https://github.com/hlxsites/vg-macktrucks-com/issues/589 we take up this functionality @WendyKruger @BeckyMedlin

mollyaljenkins commented 3 months ago

Further discussion needed for AEM Assets

BeckyMedlin commented 3 months ago

Per discussion with @WendyKruger and @ZoeBeykirch, AEM Assets doesn't need to be a requirement for this ticket @mollyaljenkins.

amglebihan commented 2 months ago

I'm pasting a Slack conversation about this between Syb, Riya Midha and Harsh Shiki from Adobe. It looks like we'll have to look into option 2 mentioned by Harsh:

Riya Midha: Hey, we looked at the sample videos you shared. Currently the customisation required looks very specific to your website CSS and can be achieved by building a player wrapper on the opensource video js player. Like Ankush shared, this player should be easy to implement at you end and you can use the DM open API manifest URLs to play videos adaptively to avoid issues with progressive playback. Currently updating the player capabilities is not in our short term roadmap. Have you evaluated this approach at your end? I see on our side that video deliveries are happening for your account, is that via this approach or something else?

Sybren Wartna: I haven’t seen a message by Ankush. Could you please explain what is meant by DM open API manifest URLs? Just the URLs that are visible in the iframe?

Harsh Chiki: For video delivery there are 2 kinds of deliveries supported:

With (2), you can have your own player, and plug the manifest URLs, for playback based on your requirements

BeckyMedlin commented 2 months ago

@mollyaljenkins @ZoeBeykirch Let's work with @amglebihan to determine if option 2 will meet the end user's needs and, if so, create some user stories.

BeckyMedlin commented 1 month ago

@ZoeBeykirch to schedule time with @amglebihan to determine requirements for this option.