search

hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

Performance Specifications #90 #691

Closed jonatan-lledo-netcentric closed 1 month ago

jonatan-lledo-netcentric commented 2 months ago

Update

#

Fix #90

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [b81fb17](https://github.com/hlxsites/vg-macktrucks-com/commit/b81fb17d1176a480f93efd656205a458f8fd40df) :white_check_mark: (latest) * [105c2bd](https://github.com/hlxsites/vg-macktrucks-com/commit/105c2bd35c21d69781299bca5223c2d4330ab651) :white_check_mark: * [8e71f3b](https://github.com/hlxsites/vg-macktrucks-com/commit/8e71f3bfaea762ff40082dde2ab42c37ea451722) :white_check_mark: * [cd5e404](https://github.com/hlxsites/vg-macktrucks-com/commit/cd5e404de68a4a590bae94e287d9301f49fffed6) :white_check_mark: * [143c8ba](https://github.com/hlxsites/vg-macktrucks-com/commit/143c8ba215154c31702bac5f988827ea6a6d7d7e) :white_check_mark: * [474926f](https://github.com/hlxsites/vg-macktrucks-com/commit/474926f7bed432b5c99ea65a45c2faf1a53fa0f3) :white_check_mark: * [7b0c1fa](https://github.com/hlxsites/vg-macktrucks-com/commit/7b0c1fa7efc958dcee1823b124035890f51440be) :white_check_mark: * [0a21f9c](https://github.com/hlxsites/vg-macktrucks-com/commit/0a21f9c35a1b72826fc652cba3e30e735b73873a) :white_check_mark: * [ca9be88](https://github.com/hlxsites/vg-macktrucks-com/commit/ca9be88ede14a9a2ca61fae4a8e15a5b8de13472) :white_check_mark: * [fb3949e](https://github.com/hlxsites/vg-macktrucks-com/commit/fb3949e163cbb48eaa43d489b6068cadc6246632) :white_check_mark: * [3622fb1](https://github.com/hlxsites/vg-macktrucks-com/commit/3622fb1f13b536fa68e2a1340655b1c8c6822060) :white_check_mark: * [0d20765](https://github.com/hlxsites/vg-macktrucks-com/commit/0d2076545d653f38f2de5d161e642d846d2eed38) :white_check_mark: * [1d31089](https://github.com/hlxsites/vg-macktrucks-com/commit/1d310898e0c84a28153158f1e4959ce35c187673) :white_check_mark: * [3329d17](https://github.com/hlxsites/vg-macktrucks-com/commit/3329d17f9734d51e6f64b7178f0684a4e355d372) :white_check_mark: * [b2058b5](https://github.com/hlxsites/vg-macktrucks-com/commit/b2058b542b98a1a61946ffdcee3c936df50a1b43) :white_check_mark: * [d47b52f](https://github.com/hlxsites/vg-macktrucks-com/commit/d47b52f26de0ddc5019ed948d49c1c8ed9950d69) :white_check_mark: * [d892b86](https://github.com/hlxsites/vg-macktrucks-com/commit/d892b86e8455deeabb07940147bf0c4ef4bae768) :white_check_mark: * [543aa4c](https://github.com/hlxsites/vg-macktrucks-com/commit/543aa4c66408c52e0763d28e7fa32a79bbd903d8) :white_check_mark: * [f7d541d](https://github.com/hlxsites/vg-macktrucks-com/commit/f7d541d16a9b3cd497e39e48fbc2619dd88f347c) :white_check_mark: * [4d77292](https://github.com/hlxsites/vg-macktrucks-com/commit/4d772922002b6f1ad7da0573305ba43ffc309525) :white_check_mark: * [a96f478](https://github.com/hlxsites/vg-macktrucks-com/commit/a96f478131190f19e60907b1de68754dbc735a1d) :white_check_mark: * [7df7527](https://github.com/hlxsites/vg-macktrucks-com/commit/7df7527c7db2a3af6d714144bf0da05c81bef900) :white_check_mark: * [5ce1c70](https://github.com/hlxsites/vg-macktrucks-com/commit/5ce1c70b64ca34aaba4dd75f30d85735568a9af7) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/drafts/jlledo/v2/solutions/mp8/pdp-mp8 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
cogniSyb commented 2 months ago

Could you change the loader to the one that’s used in the Truck Configurator?

cogniSyb commented 2 months ago

Some details in styling and behaviour need to be updated to follow v2-tabbed-carousel. For example you could replace --tab-inactive-text-color and --tab-inactive-border-color with their counterparts in that block.

The button "Download Specs" needs to get the exact look & feel of the button used in redesign.

The key specs and other places where we use capitals need to be bold and the font size adjusted, as we do elsewhere in the redesign.