hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

NFR: add custom decorateIcons script for helix v5 #704

Closed cogniSyb closed 1 month ago

cogniSyb commented 2 months ago

From vg-volvotrucks-us created by cogniSyb: hlxsites/vg-volvotrucks-us#621

Context/Description

In PR hlxsites/vg-volvotrucks-us#604 we noticed issues with icons when upgrading to helix v5. This is reported in hlxsites/vg-volvotrucks-us#608. After investigation, we concluded that moving to the current version of the decorateIcons script of aem.js is impossible.

Our need of adapting icons to their context is of high importance. Migrating to another technique would mean:

Hence, it has been decided to move to one generic script for Mack Trucks and Volvo Trucks and use that instead of the function in aem.js

Acceptance Criteria

Editor AC:

Non-functional AC:

Out of scope

No response

Note

Due to the MT script for loading icons is more efficient, overall performance will be improved. It might be that this change will have a positive impact on hlxsites/vg-volvotrucks-us#600

Technical details

Copy the code of #700; apply the same change as in hlxsites/vg-volvotrucks-us#621

Attachment / link to Figma

No response

girishdigrajkar commented 1 month ago

Validated and able to get the correct results hence, closing the issue.