hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

Add custom decorateIcons script for helix v5 #704 #716

Closed cogniSyb closed 1 month ago

cogniSyb commented 1 month ago

Fix #704

Test URLs:

Changes:

The following blocks are changed: Block Test URL Comment
[header] Before After Hover over logo; check only on desktop
[footer] Before After Check logo icon, focus states, functionality of scroll to top button
[modal] Before After Open modal in link in hero
[v2-accordion] Before After Simple regression test of icons
[v2-accordion-column] Before After Simple regression test of icons
[v2-feature-carousel] Before After Simple regression test of icons
[v2-hotspots] Before After Simple regression test of icons
[v2-images-grid] Before After Arrows when modal of block is open; check only on desktop
[v2-inpage-navigation] Before After Dropdown icon; check only on mobile
[v2-product-listing] Before After Dropdown icon; check only on mobile
[v2-truck-lineup] Before After Arrows on hover; check only on desktop
aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [6abd422](https://github.com/hlxsites/vg-macktrucks-com/commit/6abd42217b26f300b855f1d45e9a89cf30b56936) :white_check_mark: (latest) * [24825e6](https://github.com/hlxsites/vg-macktrucks-com/commit/24825e6217c997ec05a04f188f7d0a69946804bc) :white_check_mark: * [928d993](https://github.com/hlxsites/vg-macktrucks-com/commit/928d993c76758d0861508120384216fc821143f1) :white_check_mark: * [cc2692b](https://github.com/hlxsites/vg-macktrucks-com/commit/cc2692b1f65c03ff8a4fcc9c7f5fee953ad90fb5) :white_check_mark: * [e0f8028](https://github.com/hlxsites/vg-macktrucks-com/commit/e0f80280ca3cf5f685eb86f7d31aff4b2ff65d40) :white_check_mark: * [91481d4](https://github.com/hlxsites/vg-macktrucks-com/commit/91481d476c14ec63a922d9f3a53155f1c44bba3f) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/syb/page/homepage PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/syb/page/pdp/lr PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/syb/page/trucks/all-trucks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/syb/page/trucks/segment-landing PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-accordi
on&index=0
PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-feature
-carousel&index=0
PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-hotspot
s&index=0
PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-images-
grid&index=0
PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
girishdigrajkar commented 1 month ago

Validated and able to get the correct results hence, closing the issue.