search

hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 28 forks source link

Bug: [performance-specifications] Block Critical Issues #721

Closed ZoeBeykirch closed 4 months ago

ZoeBeykirch commented 4 months ago

Issue Type

Bug

Summary

Bug: [performance-specifications] - Missing engine graphs, background color, hidden titles, 404 error links, missing graph data, registered trademark sizing, horsepower data displayed.

Priority

Blocker

Description

There are multiple issues with the [performance-specifications] block that was recently deployed in Release 14 https://github.com/hlxsites/vg-macktrucks-com/issues/90 in https://github.com/hlxsites/vg-macktrucks-com/pull/691 that must be resolved before we can publish this block on the website.

  1. Only MP8 engine is in the Sidekick library, MP7 and MP8HE engines are missing.
  2. The block background is white and not black as specified in the design.
  3. When a user selects the engine model name in the top tabbed carousel, the title of the engine model that the user has selected disappears.
  4. Anytime a user clicks on the "Download Specs" button, they are directed to a 404 error page.
  5. All data for MaxiCruise engine graph is missing as seen in the below screenshot.
  6. The registered trademark for MaxiCruise is too large, should match the size of what is presented in Econodyne and Maxidyne engines.
  7. Only the Torque data on the graph should be displayed, the HorsePower should not be displayed as the requirements and updated data graphs in the ticket specify.

Affected Device Classes

Mobile, Tablet, Desktop

Affected Browsers/Devices and Versions

All browsers

Steps to Reproduce

  1. Navigate to Mack Trucks pre-production environment and test MP8 page that uses the new performance spec block that was copied from the AEM Sidekick library
  2. When previewing the page, scroll down to performance spec block
  3. See JSON file

Expected Results

image

Actual Results

Image

Attachment

No response

cogniSyb commented 4 months ago

@ZoeBeykirch the block is adjusted to be part of a redesign page. So it must be added to a page with Metadata Style set to redesign-v2. Then, the section needs to have adjustments: Section Metadata Style set to black-background

Adding this class to the page will break other blocks. This is not unique in this case; there’s no requirements for making everything backwards compatible. Hence I suggest to set up a page with V2 blocks, like https://develop--vg-macktrucks-com--hlxsites.hlx.page/drafts/jlledo/v2/solutions/mp8/pdp-mp8

ZoeBeykirch commented 4 months ago

@cogniSyb Thank you for explaining the requirements to use this block, that takes care of # 2 and 3 in the above list, but 1, 4-7 are still present after adding the style metadata - https://main--vg-macktrucks-com--hlxsites.hlx.page/powertrain-and-suspensions/engines/mp8/

ZoeBeykirch commented 4 months ago

Got all of the engine graphs working after a support call with @santi-homps ! Closing this ticket, and will need to update the sidekick library with new requirements for getting the block to work