search

hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

collage grid style #605 #741

Closed jonatan-lledo-netcentric closed 3 days ago

jonatan-lledo-netcentric commented 2 weeks ago

Fix #605

Test URLs:

aem-code-sync[bot] commented 2 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [9e39f86](https://github.com/hlxsites/vg-macktrucks-com/commit/9e39f860013f91ff0bf9220ba099884b02ce716d) :white_check_mark: (latest) * [74073eb](https://github.com/hlxsites/vg-macktrucks-com/commit/74073eb3f74e28a77f2b3ef8e524b75828dd3199) :white_check_mark: * [dde0fd1](https://github.com/hlxsites/vg-macktrucks-com/commit/dde0fd1dbd205bbe8cddf389cb3303e7378ab06a) :white_check_mark: * [6698cdd](https://github.com/hlxsites/vg-macktrucks-com/commit/6698cddcde07bdf45e02581aaac5f31c2fe405f7) :white_check_mark: * [5fe0b11](https://github.com/hlxsites/vg-macktrucks-com/commit/5fe0b113ec2cc22b6238e46521f8d0619b3a691c) :white_check_mark: * [4d7ffb1](https://github.com/hlxsites/vg-macktrucks-com/commit/4d7ffb1c7b8f5f23dd9b9ff9871fbadf14b19386) :white_check_mark: * [a017cdc](https://github.com/hlxsites/vg-macktrucks-com/commit/a017cdc021b47032988f2a0220c5a0350bdc6c1e) :white_check_mark: * [a811387](https://github.com/hlxsites/vg-macktrucks-com/commit/a8113873780bde08d6c69ec2ad011d37be3b23c3) :white_check_mark: * [a08f54c](https://github.com/hlxsites/vg-macktrucks-com/commit/a08f54c6bda7573ccabc22ba9459efc9311f584d) :white_check_mark: * [b15180b](https://github.com/hlxsites/vg-macktrucks-com/commit/b15180b7efdfbf0b342c73dfe55362f02f9c9de8) :white_check_mark: * [4b33b11](https://github.com/hlxsites/vg-macktrucks-com/commit/4b33b11002f882fc6c84674d41c16247d1d2be65) :white_check_mark: * [baeddca](https://github.com/hlxsites/vg-macktrucks-com/commit/baeddca1aa9e6c9123daf30bfef4f545ebf3133d) :white_check_mark: * [39f1167](https://github.com/hlxsites/vg-macktrucks-com/commit/39f1167f4b4545385e00450a036d79dff7628100) :white_check_mark: * [76e44bf](https://github.com/hlxsites/vg-macktrucks-com/commit/76e44bf6b17ccf6d0726e4fb9e75664c0affaff3) :white_check_mark: * [d3df39f](https://github.com/hlxsites/vg-macktrucks-com/commit/d3df39fbd62ced7305aa0a9420908289484f3e26) :white_check_mark: * [b9398fa](https://github.com/hlxsites/vg-macktrucks-com/commit/b9398faf583f741e64ce7cf841965a52c8a1bf24) :white_check_mark: * [04f9c10](https://github.com/hlxsites/vg-macktrucks-com/commit/04f9c10b2d18b340920e250a6da9d692030aa829) :white_check_mark: * [e9a2cfe](https://github.com/hlxsites/vg-macktrucks-com/commit/e9a2cfeefb0eb1789a1af769f6e9473039ea7145) :white_check_mark: * [418df28](https://github.com/hlxsites/vg-macktrucks-com/commit/418df2827dfcbec5b4c4379621cbb0bbc59cfd86) :white_check_mark: * [b0035ad](https://github.com/hlxsites/vg-macktrucks-com/commit/b0035ad7e30af8d21ea9d3d07e17dccfcbc77bfc) :white_check_mark: * [2eb9566](https://github.com/hlxsites/vg-macktrucks-com/commit/2eb9566f685a534019c683b8c52690f4a53fbd8f) :white_check_mark: * [44ea08f](https://github.com/hlxsites/vg-macktrucks-com/commit/44ea08f931aad0aa46ef6f5871a88cc685d10c03) :white_check_mark: * [003d988](https://github.com/hlxsites/vg-macktrucks-com/commit/003d988d479be771d25d61c49ef89fcaf8b544a4) :white_check_mark: * [e3fcdf3](https://github.com/hlxsites/vg-macktrucks-com/commit/e3fcdf30d96835bc9dfd191705a8a77f1640afbf) :white_check_mark: * [dc6b1d5](https://github.com/hlxsites/vg-macktrucks-com/commit/dc6b1d5e13f33ed5ec5a82fa8a6639bc7af4946f) :white_check_mark: * [8079350](https://github.com/hlxsites/vg-macktrucks-com/commit/80793500224a738140eca45355a9ca6ca2742453) :white_check_mark: * [1b5f80c](https://github.com/hlxsites/vg-macktrucks-com/commit/1b5f80c97dd4491dfeb41c30df516d4a4945453d) :white_check_mark:
aem-code-sync[bot] commented 2 weeks ago
Page Scores Audits Google
/drafts/jlledo/v2/category-collage-demo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
amglebihan commented 2 weeks ago

@jonatan-lledo-netcentric I'm wondering if the whole tile should be clickable. However, if we include a video, I understand that we need to ensure that users can interact with the play/pause buttons, so making the whole tile clickable might be an issue in the case of having a video. If we need to make the whole title clickable, we could add a z-index to the play/pause buttons.

santi-homps commented 2 weeks ago

Things to consider... -Is the naming correct? since we have other "collage" items I dont think that the category part is right. Also we are not getting all categories from the sharepoint but rather adding images with links, so it could work for other things as well. In that case... shouldn't we plan for not having always 9 items in the list or declare that as a "must"?. -If we are going to reuse this block for other collages maybe we could identify this as a "categories" variant? and then have the other variants reuse part of it

Screenshot 2024-06-11 at 12 15 00 PM
santi-homps commented 2 weeks ago

I think something broke now...

Screenshot 2024-06-14 at 4 39 27 PM