search

hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

Bug: Modal broken with Helix 5 upgrade #752

Open cogniSyb opened 1 week ago

cogniSyb commented 1 week ago

Issue Type

Bug

Summary

[modal]

Priority

Blocker

Description

As mentioned in #714. Modal functionality should work the same as for Volvo Trucks

Affected Device Classes

Mobile, Tablet, Desktop

Affected Browsers/Devices and Versions

All

Steps to Reproduce

  1. Navigate to https://714-spike-helix-v5--vg-macktrucks-com--hlxsites.hlx.page/
  2. Observe the modal not being loaded

Expected Results

Modal present

Actual Results

Modal not present

Attachment

No response

verareljic commented 1 week ago

Please check internally and provide an update @ZoeBeykirch

ZoeBeykirch commented 2 days ago

There are some video players using modals, and that is the only kind of modal required.