search

hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

Bug: Video in modal broken #763

Closed cogniSyb closed 4 days ago

cogniSyb commented 1 week ago

Issue Type

Bug

Summary

[modal] video creation broken

Priority

Blocker

Description

Screenshot 2024-06-21 at 07 12 20

Refactoring of video-related functions for #589 broke existing functionality. I traced it back to this change: https://github.com/hlxsites/vg-macktrucks-com/commit/01641b8fa10451e398d12600d747469b5889f39a

Affected Device Classes

Mobile, Tablet, Desktop

Affected Browsers/Devices and Versions

All

Steps to Reproduce

  1. Navigate to https://develop--vg-macktrucks-com--hlxsites.hlx.page/drafts/syb/block/v2-testimonial-video
  2. Click the video link in the second or third testimonial
  3. Observe the modal not opening

Expected Results

A modal is shown, with a video playing automatically.

Actual Results

No modal is being shown

Attachment

No response

girishdigrajkar commented 1 week ago

Validated and now model opens and user is able to play all the three videos and no errors noted in console.