hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

Bug: [V2 product listing] broken with Helix 5 upgrade #777

Open ZoeBeykirch opened 6 days ago

ZoeBeykirch commented 6 days ago

Issue Type

Bug

Summary

The V2 product listing block is not working properly, likely due to the helix 5 upgrade

Priority

Blocker

Description

The V2 product listing is not displaying properly and may need to be refactored to work with the new helix 5 upgrade requirements.

Affected Device Classes

Mobile, Tablet, Desktop

Affected Browsers/Devices and Versions

All browsers and devices.

Steps to Reproduce

  1. Navigate to example page: https://main--vg-macktrucks-com--hlxsites.hlx.page/trucks/index-new
  2. This block was copied and pasted from the AEM Sidekick library and does not function the same way it is previewed in the block library.

Expected Results

See the V2 Product Listing block in Sidekick Library for expected results: https://main--vg-macktrucks-com--hlxsites.hlx.live/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-product-listing&index=0

Image

Actual Results

Image

Image

Attachment

No response

santi-homps commented 6 days ago

Some content issues found here and fixed.

Screenshot 2024-06-26 at 4 33 35 PM
BeckyMedlin commented 6 days ago

@Kannan-CM Also reviewed this issue with the following findings:

[6:31 AM] Chinnamuthan Kannan The section height is set to 400px by default and it doesn't adjust the height based on the content. So, we need to probably limit the text.

On Big Screens:

image

On Laptop Screens:

image

The heading is occupying the 2nd line which pushed the text and buttons down. Advised @WendyKruger to submit tickets in Teams if she needs additional assistance from CMS or if she would like to submit an enhancment request.